From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Kevin Hao <haokexin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Scott Wood <scottwood@freescale.com>, Paul Mackerras <paulus@samba.org>
Subject: Re: [v2, 1/3] powerpc32: booke: fix the build error when CRASH_DUMP is enabled
Date: Wed, 20 Jul 2016 19:10:19 +1000 (AEST) [thread overview]
Message-ID: <3rvWMv6fJzz9t0v@ozlabs.org> (raw)
In-Reply-To: <1468372480-6453-2-git-send-email-haokexin@gmail.com>
On Wed, 2016-13-07 at 01:14:38 UTC, Kevin Hao wrote:
> In the current code, the RELOCATABLE will be forcedly enabled when
> enabling CRASH_DUMP. But for ppc32, the RELOCABLE also depend on
> ADVANCED_OPTIONS and select NONSTATIC_KERNEL. This will cause the
> following build error when CRASH_DUMP=y && ADVANCED_OPTIONS=n
> because the select of NONSTATIC_KERNEL doesn't take effect.
> arch/powerpc/include/asm/io.h: In function 'virt_to_phys':
> arch/powerpc/include/asm/page.h:113:26: error: 'virt_phys_offset' undeclared (first use in this function)
> #define VIRT_PHYS_OFFSET virt_phys_offset
> ^
> It doesn't have any strong reasons to make the RELOCATABLE depend on
> ADVANCED_OPTIONS. So remove this dependency to fix this issue.
>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/da4230714662278781d007fb2b
cheers
next prev parent reply other threads:[~2016-07-20 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 1:14 [PATCH v2 0/3] powerpc: tweak the kernel options for CRASH_DUMP and RELOCATABLE Kevin Hao
2016-07-13 1:14 ` [PATCH v2 1/3] powerpc32: booke: fix the build error when CRASH_DUMP is enabled Kevin Hao
2016-07-20 9:10 ` Michael Ellerman [this message]
2016-07-13 1:14 ` [PATCH v2 2/3] powerpc: merge the RELOCATABLE config entries for ppc32 and ppc64 Kevin Hao
2016-07-13 1:14 ` [PATCH v2 3/3] powerpc32: kill RELOCATABLE_PPC32 Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3rvWMv6fJzz9t0v@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=haokexin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).