* Re: [PATCH] cxl: remove dead Kconfig options
2016-07-04 7:12 [PATCH] cxl: remove dead Kconfig options Andrew Donnellan
@ 2016-07-04 13:16 ` Ian Munsie
2016-07-08 7:06 ` Andrew Donnellan
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Ian Munsie @ 2016-07-04 13:16 UTC (permalink / raw)
To: andrew.donnellan
Cc: linuxppc-dev, Matthew R. Ochs, linux-scsi, manoj, clombard,
fbarrat
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] cxl: remove dead Kconfig options
2016-07-04 7:12 [PATCH] cxl: remove dead Kconfig options Andrew Donnellan
2016-07-04 13:16 ` Ian Munsie
@ 2016-07-08 7:06 ` Andrew Donnellan
2016-07-12 20:31 ` Matthew R. Ochs
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Andrew Donnellan @ 2016-07-08 7:06 UTC (permalink / raw)
To: linuxppc-dev; +Cc: clombard, linux-scsi, mrochs, fbarrat, manoj, imunsie
On 04/07/16 17:12, Andrew Donnellan wrote:
> Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only
> needed to coordinate the merging of the cxlflash driver. Also remove the
> stub implementation of cxl_perst_reloads_same_image() in cxlflash which is
> only used if CXL_EEH isn't defined (i.e. never).
>
> Suggested-by: Ian Munsie <imunsie@au1.ibm.com>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
> ---
>
> Applies on top of powerpc#next
I'm going to rebase this on top of the current Mellanox CX-4 series shortly.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] cxl: remove dead Kconfig options
2016-07-04 7:12 [PATCH] cxl: remove dead Kconfig options Andrew Donnellan
2016-07-04 13:16 ` Ian Munsie
2016-07-08 7:06 ` Andrew Donnellan
@ 2016-07-12 20:31 ` Matthew R. Ochs
2016-07-14 2:02 ` Martin K. Petersen
2016-07-18 4:52 ` [PATCH v2] " Andrew Donnellan
4 siblings, 0 replies; 11+ messages in thread
From: Matthew R. Ochs @ 2016-07-12 20:31 UTC (permalink / raw)
To: Andrew Donnellan
Cc: linuxppc-dev, clombard, linux-scsi, fbarrat, manoj, imunsie
> On Jul 4, 2016, at 2:12 AM, Andrew Donnellan =
<andrew.donnellan@au1.ibm.com> wrote:
>=20
> Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were =
only
> needed to coordinate the merging of the cxlflash driver. Also remove =
the
> stub implementation of cxl_perst_reloads_same_image() in cxlflash =
which is
> only used if CXL_EEH isn't defined (i.e. never).
>=20
> Suggested-by: Ian Munsie <imunsie@au1.ibm.com>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] cxl: remove dead Kconfig options
2016-07-04 7:12 [PATCH] cxl: remove dead Kconfig options Andrew Donnellan
` (2 preceding siblings ...)
2016-07-12 20:31 ` Matthew R. Ochs
@ 2016-07-14 2:02 ` Martin K. Petersen
2016-07-14 2:05 ` Andrew Donnellan
2016-07-18 4:52 ` [PATCH v2] " Andrew Donnellan
4 siblings, 1 reply; 11+ messages in thread
From: Martin K. Petersen @ 2016-07-14 2:02 UTC (permalink / raw)
To: Andrew Donnellan
Cc: linuxppc-dev, imunsie, mrochs, linux-scsi, manoj, clombard,
fbarrat
>>>>> "Andrew" == Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
Andrew> Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they
Andrew> were only needed to coordinate the merging of the cxlflash
Andrew> driver. Also remove the stub implementation of
Andrew> cxl_perst_reloads_same_image() in cxlflash which is only used if
Andrew> CXL_EEH isn't defined (i.e. never).
This patch straddles a few subsystems. Did you intend for me to queue it
through SCSI?
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] cxl: remove dead Kconfig options
2016-07-14 2:02 ` Martin K. Petersen
@ 2016-07-14 2:05 ` Andrew Donnellan
2016-07-14 2:07 ` Andrew Donnellan
2016-07-14 2:22 ` Martin K. Petersen
0 siblings, 2 replies; 11+ messages in thread
From: Andrew Donnellan @ 2016-07-14 2:05 UTC (permalink / raw)
To: Martin K. Petersen
Cc: linuxppc-dev, imunsie, mrochs, linux-scsi, manoj, clombard,
fbarrat
On 14/07/16 12:02, Martin K. Petersen wrote:
>>>>>> "Andrew" == Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
>
> Andrew> Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they
> Andrew> were only needed to coordinate the merging of the cxlflash
> Andrew> driver. Also remove the stub implementation of
> Andrew> cxl_perst_reloads_same_image() in cxlflash which is only used if
> Andrew> CXL_EEH isn't defined (i.e. never).
>
> This patch straddles a few subsystems. Did you intend for me to queue it
> through SCSI?
Sorry for not stating explicitly - I'd like this taken through powerpc
as the cxlflash change is incidental to the cxl changes.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] cxl: remove dead Kconfig options
2016-07-14 2:05 ` Andrew Donnellan
@ 2016-07-14 2:07 ` Andrew Donnellan
2016-07-14 2:22 ` Martin K. Petersen
1 sibling, 0 replies; 11+ messages in thread
From: Andrew Donnellan @ 2016-07-14 2:07 UTC (permalink / raw)
To: Martin K. Petersen
Cc: clombard, linux-scsi, mrochs, fbarrat, manoj, imunsie,
linuxppc-dev
On 14/07/16 12:05, Andrew Donnellan wrote:
> Sorry for not stating explicitly - I'd like this taken through powerpc
> as the cxlflash change is incidental to the cxl changes.
I'll also be submitting a v2 that applies on top of another cxl series
that hasn't been merged yet.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] cxl: remove dead Kconfig options
2016-07-14 2:05 ` Andrew Donnellan
2016-07-14 2:07 ` Andrew Donnellan
@ 2016-07-14 2:22 ` Martin K. Petersen
1 sibling, 0 replies; 11+ messages in thread
From: Martin K. Petersen @ 2016-07-14 2:22 UTC (permalink / raw)
To: Andrew Donnellan
Cc: Martin K. Petersen, linuxppc-dev, imunsie, mrochs, linux-scsi,
manoj, clombard, fbarrat
>>>>> "Andrew" == Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
>> This patch straddles a few subsystems. Did you intend for me to queue
>> it through SCSI?
Andrew> Sorry for not stating explicitly - I'd like this taken through
Andrew> powerpc as the cxlflash change is incidental to the cxl changes.
No problem.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] cxl: remove dead Kconfig options
2016-07-04 7:12 [PATCH] cxl: remove dead Kconfig options Andrew Donnellan
` (3 preceding siblings ...)
2016-07-14 2:02 ` Martin K. Petersen
@ 2016-07-18 4:52 ` Andrew Donnellan
2016-07-18 4:59 ` Andrew Donnellan
2016-07-20 9:10 ` [v2] " Michael Ellerman
4 siblings, 2 replies; 11+ messages in thread
From: Andrew Donnellan @ 2016-07-18 4:52 UTC (permalink / raw)
To: linuxppc-dev; +Cc: clombard, linux-scsi, mrochs, fbarrat, manoj, imunsie
Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only
needed to coordinate the merging of the cxlflash driver. Also remove the
stub implementation of cxl_perst_reloads_same_image() in cxlflash which is
only used if CXL_EEH isn't defined (i.e. never).
Suggested-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
---
Applies on top of powerpc#next, now that the Mellanox CX-4 patches have
been applied.
---
drivers/misc/cxl/Kconfig | 10 ----------
drivers/scsi/cxlflash/main.h | 4 ----
2 files changed, 14 deletions(-)
diff --git a/drivers/misc/cxl/Kconfig b/drivers/misc/cxl/Kconfig
index 8d76770..b75cf83 100644
--- a/drivers/misc/cxl/Kconfig
+++ b/drivers/misc/cxl/Kconfig
@@ -7,14 +7,6 @@ config CXL_BASE
default n
select PPC_COPRO_BASE
-config CXL_KERNEL_API
- bool
- default n
-
-config CXL_EEH
- bool
- default n
-
config CXL_AFU_DRIVER_OPS
bool
default n
@@ -23,8 +15,6 @@ config CXL
tristate "Support for IBM Coherent Accelerators (CXL)"
depends on PPC_POWERNV && PCI_MSI && EEH
select CXL_BASE
- select CXL_KERNEL_API
- select CXL_EEH
select CXL_AFU_DRIVER_OPS
default m
help
diff --git a/drivers/scsi/cxlflash/main.h b/drivers/scsi/cxlflash/main.h
index eb9d8f7..a893408 100644
--- a/drivers/scsi/cxlflash/main.h
+++ b/drivers/scsi/cxlflash/main.h
@@ -100,8 +100,4 @@ struct asyc_intr_info {
#define SCAN_HOST 0x04
};
-#ifndef CONFIG_CXL_EEH
-#define cxl_perst_reloads_same_image(_a, _b) do { } while (0)
-#endif
-
#endif /* _CXLFLASH_MAIN_H */
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2] cxl: remove dead Kconfig options
2016-07-18 4:52 ` [PATCH v2] " Andrew Donnellan
@ 2016-07-18 4:59 ` Andrew Donnellan
2016-07-20 9:10 ` [v2] " Michael Ellerman
1 sibling, 0 replies; 11+ messages in thread
From: Andrew Donnellan @ 2016-07-18 4:59 UTC (permalink / raw)
To: linuxppc-dev; +Cc: clombard, linux-scsi, mrochs, fbarrat, manoj, imunsie
On 18/07/16 14:52, Andrew Donnellan wrote:
> Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only
> needed to coordinate the merging of the cxlflash driver. Also remove the
> stub implementation of cxl_perst_reloads_same_image() in cxlflash which is
> only used if CXL_EEH isn't defined (i.e. never).
>
> Suggested-by: Ian Munsie <imunsie@au1.ibm.com>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
> Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
>
> ---
>
> Applies on top of powerpc#next, now that the Mellanox CX-4 patches have
> been applied.
As it turns out, this patch is exactly identical to V1... oh well.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [v2] cxl: remove dead Kconfig options
2016-07-18 4:52 ` [PATCH v2] " Andrew Donnellan
2016-07-18 4:59 ` Andrew Donnellan
@ 2016-07-20 9:10 ` Michael Ellerman
1 sibling, 0 replies; 11+ messages in thread
From: Michael Ellerman @ 2016-07-20 9:10 UTC (permalink / raw)
To: Andrew Donnellan, linuxppc-dev
Cc: clombard, linux-scsi, mrochs, fbarrat, manoj, imunsie
On Mon, 2016-18-07 at 04:52:57 UTC, Andrew Donnellan wrote:
> Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only
> needed to coordinate the merging of the cxlflash driver. Also remove the
> stub implementation of cxl_perst_reloads_same_image() in cxlflash which is
> only used if CXL_EEH isn't defined (i.e. never).
>
> Suggested-by: Ian Munsie <imunsie@au1.ibm.com>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
> Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1e44727a0b220f6ead12fefcff
cheers
^ permalink raw reply [flat|nested] 11+ messages in thread