From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3shWzz2QzMzDrPM for ; Sun, 25 Sep 2016 13:00:15 +1000 (AEST) In-Reply-To: <20160919105855.435AF1A2455@localhost.localdomain> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Scott Wood From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [v2] powerpc: fix usage of _PAGE_RO in hugepage Message-Id: <3shWzz09hFz9s5g@ozlabs.org> Date: Sun, 25 Sep 2016 13:00:14 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2016-19-09 at 10:58:54 UTC, Christophe Leroy wrote: > On some CPUs like the 8xx, _PAGE_RW hence _PAGE_WRITE is defined > as 0 and _PAGE_RO has to be set when a page is not writable > > _PAGE_RO is defined by default in pte-common.h, however BOOK3S/64 > doesn't include that file so _PAGE_RO has to be defined explicitly > in book3s/64/pgtable.h > > fixes: a7b9f671f2d14 ("powerpc32: adds handling of _PAGE_RO") > Signed-off-by: Christophe Leroy > Reviewed-by: Aneesh Kumar K.V Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/6b8cb66a6a7cc182b47da6a0a1 cheers