From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3spfzx19sszDrMD for ; Wed, 5 Oct 2016 13:36:29 +1100 (AEDT) In-Reply-To: <1469764534-26948-1-git-send-email-andrew.donnellan@au1.ibm.com> To: Andrew Donnellan , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: clombard@linux.vnet.ibm.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, fbarrat@linux.vnet.ibm.com, julia.lawall@lip6.fr, imunsie@au1.ibm.com, elfring@users.sourceforge.net Subject: Re: cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put() Message-Id: <3spfzw6LSRz9t0t@ozlabs.org> Date: Wed, 5 Oct 2016 13:36:28 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2016-29-07 at 03:55:34 UTC, Andrew Donnellan wrote: > Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use > for_each_child_of_node() rather than a hand-coded for loop. > > Remove the useless of_node_put(afu_np) call after the loop, where it's > guaranteed that afu_np == NULL. > > Reported-by: SF Markus Elfring > Reported-by: Julia Lawall > Signed-off-by: Andrew Donnellan > Reviewed-by: Frederic Barrat Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/735840b44bcc998e2574faf63d1aaa cheers