linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,
	Christophe Lombard <clombard@linux.vnet.ibm.com>,
	Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
	Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
	Ian Munsie <imunsie@au1.ibm.com>,
	Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	gkurz@linux.vnet.ibm.com
Subject: Re: cxl: Do adapter fence check before handling afu interrupt
Date: Tue, 22 Nov 2016 11:34:17 +1100 (AEDT)	[thread overview]
Message-ID: <3tN60n2c0Hz9t2D@ozlabs.org> (raw)
In-Reply-To: <1479305373-20539-1-git-send-email-vaibhav@linux.vnet.ibm.com>

On Wed, 2016-11-16 at 14:09:33 UTC, Vaibhav Jain wrote:
> If an afu interrupt is in flight when an eeh error is triggered the
> control still reaches the function native_irq_multiplexed and the
> PE-Handle read from the CXL_PSL_PEHandle_An register is 0xffff. The
> function then erroneously assumes that the interrupt belonged to a
> detached context and generates a warning with full stack dump in the
> kernel log complaining:
> 
> "Unable to demultiplex CXL PSL IRQ for PE 65535 DSISR ffffffff DAR
> ffffffff. (Possible AFU HW issue - was a term/remove acked with
> outstanding transactions"
> 
> To fix this the patch adds new code to the function
> native_irq_multiplexed function to compares the read value of register
> CXL_PSL_PEHandle_An to ~0ULL. If true then logs a warning message
> saying that the interrupt is being ignored and returns IRQ_HANDLED from
> the irq handler.
> 
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/abf051be684be768c1ee079514f4d0

cheers

      reply	other threads:[~2016-11-22  0:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 14:09 [PATCH] cxl: Do adapter fence check before handling afu interrupt Vaibhav Jain
2016-11-22  0:34 ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3tN60n2c0Hz9t2D@ozlabs.org \
    --to=patch-notifications@ellerman.id.au \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=clombard@linux.vnet.ibm.com \
    --cc=fbarrat@linux.vnet.ibm.com \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=philippe.bergheaud@fr.ibm.com \
    --cc=vaibhav@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).