From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vdQ6l3k37zDqYY for ; Wed, 8 Mar 2017 18:25:51 +1100 (AEDT) In-Reply-To: <20170226060834.91303.20851.sendpatchset@Sachins-MacBook-Pro.local> To: Sachin Sant , linux-kselftest@vger.kernel.org From: Michael Ellerman Cc: Sachin Sant , linuxppc-dev@lists.ozlabs.org, shuahkh@osg.samsung.com Subject: Re: [RESEND] selftest/powerpc/alignment: Fix false failures for skipped tests Message-Id: <3vdQ6l34whz9sN5@ozlabs.org> Date: Wed, 8 Mar 2017 18:25:51 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2017-02-26 at 06:08:39 UTC, Sachin Sant wrote: > Tests under alignment subdirectory are skipped when executed on previous > generation hardware, but harness still marks them as failed. > > test: test_copy_unaligned > tags: git_version:unknown > [SKIP] Test skipped on line 26 > skip: test_copy_unaligned > selftests: copy_unaligned [FAIL] > > The MAGIC_SKIP_RETURN_VALUE value assigned to rc variable is retained till > the program exit which causes the test to be marked as failed. > > This patch resets the value before returning to the main() routine. > With this patch the test o/p is as follows: > > test: test_copy_unaligned > tags: git_version:unknown > [SKIP] Test skipped on line 26 > skip: test_copy_unaligned > selftests: copy_unaligned [PASS] > > Signed-off-by: Sachin Sant Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/a6d8a21596df041f36f4c2ccc260c4 cheers