From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: "regressions @ leemhuis . info" <regressions@leemhuis.info>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: powerpc: Fix crash introduced with commit 5657933dbb6e
Date: Tue, 14 Mar 2017 22:46:00 +1100 (AEDT) [thread overview]
Message-ID: <3vjCc82PtWz9s2G@ozlabs.org> (raw)
In-Reply-To: <20170310023351.973-1-Larry.Finger@lwfinger.net>
On Fri, 2017-03-10 at 02:33:51 UTC, Larry Finger wrote:
> Code inserted during the code merged between kernels 4.10 and 4.11-rc1
> caused an early panic quickly followed by a complete shutdown for
> PowerPC. The traceback was not displayed long enough to read or
> photograph, thus it is not reproduced here.
>
> The problem was bisected to commit 5657933dbb6e ("treewide: Move dma_ops
> from struct dev_archdata into struct device"). The problem was a missing
> copy of critical information from struct dev_archdata into struct device,
> leading to the dereference of a null pointer.
>
> This fix was suggested by Benjamin Herrenschmidt.
>
> Fixes: commit 5657933dbb6e ("treewide: Move dma_ops from struct dev_archdata into struct device")
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: regressions@leemhuis.info <regressions@leemhuis.info>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/46f401c4297a2232a037ad8801b6c8
cheers
prev parent reply other threads:[~2017-03-14 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 2:33 [PATCH] powerpc: Fix crash introduced with commit 5657933dbb6e Larry Finger
2017-03-11 17:07 ` Linus Torvalds
2017-03-14 11:46 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3vjCc82PtWz9s2G@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=regressions@leemhuis.info \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).