[PATCH] powerpc: fix sparse warning, include kernel header

[PATCH] powerpc: fix sparse warning, include kernel header

[Tobin C. Harding]

Spares emits two symbol not declared warnings. The two functions in
question are declared already in a kernel header.

Add include directive to include kernel header.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---

github issue: #37 Fix sparse errors

 arch/powerpc/kernel/swsusp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/kernel/swsusp.c b/arch/powerpc/kernel/swsusp.c
index 6ae9bd5..0050b2d 100644
--- a/arch/powerpc/kernel/swsusp.c
+++ b/arch/powerpc/kernel/swsusp.c
@@ -10,6 +10,7 @@
  */
 
 #include <linux/sched.h>
+#include <linux/suspend.h>
 #include <asm/current.h>
 #include <asm/mmu_context.h>
 #include <asm/switch_to.h>
-- 
2.7.4

Re: [PATCH] powerpc: fix sparse warning, include kernel header

[Daniel Axtens]

Hi Tobin,

I have built the kernel with the ppc6xx_defconfig with and without your
patch.

Using my smart-sparse-diff tool[1], I have confirmed the warning
disappears:

-/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:17:6: warning: symbol 'save_processor_state' was not declared. Should it be static?
-/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:31:6: warning: symbol 'restore_processor_state' was not declared. Should it be static?

As such, this patch is:

Reviewed-by: Daniel Axtens <dja@axtens.net>

Thanks for fixing this!

Regards,
Daniel

[1] https://github.com/daxtens/smart-sparse-diff

"Tobin C. Harding" <me@tobin.cc> writes:

> Spares emits two symbol not declared warnings. The two functions in
> question are declared already in a kernel header.
>
> Add include directive to include kernel header.
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
> ---
>
> github issue: #37 Fix sparse errors
>
>  arch/powerpc/kernel/swsusp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/swsusp.c b/arch/powerpc/kernel/swsusp.c
> index 6ae9bd5..0050b2d 100644
> --- a/arch/powerpc/kernel/swsusp.c
> +++ b/arch/powerpc/kernel/swsusp.c
> @@ -10,6 +10,7 @@
>   */
>  
>  #include <linux/sched.h>
> +#include <linux/suspend.h>
>  #include <asm/current.h>
>  #include <asm/mmu_context.h>
>  #include <asm/switch_to.h>
> -- 
> 2.7.4

Re: [PATCH] powerpc: fix sparse warning, include kernel header

[Tobin C. Harding]

On Fri, Mar 10, 2017 at 11:40:23AM +1100, Daniel Axtens wrote:
> Hi Tobin,
> 
> I have built the kernel with the ppc6xx_defconfig with and without your
> patch.
> 
> Using my smart-sparse-diff tool[1], I have confirmed the warning
> disappears:
> 
> -/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:17:6: warning: symbol 'save_processor_state' was not declared. Should it be static?
> -/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:31:6: warning: symbol 'restore_processor_state' was not declared. Should it be static?
> 
> As such, this patch is:
> 
> Reviewed-by: Daniel Axtens <dja@axtens.net>

Awesome, thanks Daniel

> 
> Thanks for fixing this!
> 
> Regards,
> Daniel
> 
> [1] https://github.com/daxtens/smart-sparse-diff
> 
> "Tobin C. Harding" <me@tobin.cc> writes:
> 
> > Spares emits two symbol not declared warnings. The two functions in
> > question are declared already in a kernel header.
> >
> > Add include directive to include kernel header.
> >
> > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > ---
> >
> > github issue: #37 Fix sparse errors
> >
> >  arch/powerpc/kernel/swsusp.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/powerpc/kernel/swsusp.c b/arch/powerpc/kernel/swsusp.c
> > index 6ae9bd5..0050b2d 100644
> > --- a/arch/powerpc/kernel/swsusp.c
> > +++ b/arch/powerpc/kernel/swsusp.c
> > @@ -10,6 +10,7 @@
> >   */
> >  
> >  #include <linux/sched.h>
> > +#include <linux/suspend.h>
> >  #include <asm/current.h>
> >  #include <asm/mmu_context.h>
> >  #include <asm/switch_to.h>
> > -- 
> > 2.7.4

-- 
Tobin Harding
http://tobin.cc

Re: powerpc: fix sparse warning, include kernel header

[Michael Ellerman]

On Mon, 2017-03-06 at 08:25:31 UTC, "Tobin C. Harding" wrote:
> Spares emits two symbol not declared warnings. The two functions in
> question are declared already in a kernel header.
> 
> Add include directive to include kernel header.
> 
> Signed-off-by: Tobin C. Harding <me@tobin.cc>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/1fc439c81312cd27aed553964c0d9d

cheers