From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Tobin C. Harding" <me@tobin.cc>, Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: linuxppc-dev@lists.ozlabs.org, "Tobin C. Harding" <me@tobin.cc>
Subject: Re: powerpc/ftrace: add ftrace.h, fix sparse warning
Date: Tue, 21 Mar 2017 22:36:15 +1100 (AEDT) [thread overview]
Message-ID: <3vnW3g4MrZz9s8C@ozlabs.org> (raw)
In-Reply-To: <1488790186-4828-1-git-send-email-me@tobin.cc>
On Mon, 2017-03-06 at 08:49:46 UTC, "Tobin C. Harding" wrote:
> Sparse emits warning: symbol 'prepare_ftrace_return' was not
> declared. Should it be static? prepare_ftrace_return() is called
> from assembler and should not be static. Adding a header file
> declaring the function will fix the sparse warning while adding
> documentation to the call.
>
> Add header file ftrace.h with single function declaration. Protect
> declaration with preprocessor guard so it may be included in
> assembly. Include new header in all files that call
> prepare_ftrace_return() and in ftrace.c where function is defined.
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b3a7864c6feb0fb30bc2cd37265707
cheers
prev parent reply other threads:[~2017-03-21 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 8:49 [PATCH] powerpc/ftrace: add ftrace.h, fix sparse warning Tobin C. Harding
2017-03-08 11:24 ` Michael Ellerman
2017-03-21 11:36 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3vnW3g4MrZz9s8C@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=me@tobin.cc \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).