From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vnW3g5ZBSzDqc2 for ; Tue, 21 Mar 2017 22:36:15 +1100 (AEDT) In-Reply-To: <1488790186-4828-1-git-send-email-me@tobin.cc> To: "Tobin C. Harding" , Ingo Molnar , Steven Rostedt From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, "Tobin C. Harding" Subject: Re: powerpc/ftrace: add ftrace.h, fix sparse warning Message-Id: <3vnW3g4MrZz9s8C@ozlabs.org> Date: Tue, 21 Mar 2017 22:36:15 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2017-03-06 at 08:49:46 UTC, "Tobin C. Harding" wrote: > Sparse emits warning: symbol 'prepare_ftrace_return' was not > declared. Should it be static? prepare_ftrace_return() is called > from assembler and should not be static. Adding a header file > declaring the function will fix the sparse warning while adding > documentation to the call. > > Add header file ftrace.h with single function declaration. Protect > declaration with preprocessor guard so it may be included in > assembly. Include new header in all files that call > prepare_ftrace_return() and in ftrace.c where function is defined. > > Signed-off-by: Tobin C. Harding Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/b3a7864c6feb0fb30bc2cd37265707 cheers