From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xTPFw3ffDzDr38 for ; Fri, 11 Aug 2017 22:19:48 +1000 (AEST) In-Reply-To: <20170721111644.2a6a6610@roar.ozlabs.ibm.com> To: Nicholas Piggin From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Subject: Re: powerpc/pseries: energy driver only print message when LPAR guest Message-Id: <3xTPFw2Tvlz9t32@ozlabs.org> Date: Fri, 11 Aug 2017 22:19:48 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2017-07-21 at 01:16:44 UTC, Nicholas Piggin wrote: > On Thu, 20 Jul 2017 23:03:21 +1000 > Michael Ellerman wrote: > > > Nicholas Piggin writes: > > > > > This driver currently reports the H_BEST_ENERGY is unsupported even > > > when booting in a non-LPAR environment (e.g., powernv). Prevent it. > > > > Just delete the printk(). Users don't know what that means, and > > developers have other better ways to detect that the hcall is missing if > > anyone cares. > > > > cheers > > powerpc/pseries: energy driver do not print failure message > > This driver currently reports the H_BEST_ENERGY is unsupported (even > when booting in a non-LPAR environment). This is not something the > administrator can do much with, and not significant for debugging. > > Remove it. > > Signed-off-by: Nicholas Piggin > Reviewed-by: Vaidyanathan Srinivasan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a70a0b9f4404d8edb72ca0e0272731 cheers