* [PATCH v2] macintosh: rack-meter: make of_device_ids const.
@ 2017-06-19 5:44 Arvind Yadav
2017-08-21 13:39 ` [v2] " Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-19 5:44 UTC (permalink / raw)
To: benh, mingo; +Cc: linuxppc-dev, linux-kernel
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
407 576 0 983 3d7 drivers/macintosh/rack-meter.o
File size after constify rackmeter_match.
text data bss dec hex filename
807 176 0 983 3d7 drivers/macintosh/rack-meter.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v1:
Subject was wrong. It should be constify rackmeter_match.
drivers/macintosh/rack-meter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c
index e199fd6..35582eb 100644
--- a/drivers/macintosh/rack-meter.c
+++ b/drivers/macintosh/rack-meter.c
@@ -579,7 +579,7 @@ static int rackmeter_shutdown(struct macio_dev* mdev)
return 0;
}
-static struct of_device_id rackmeter_match[] = {
+static const struct of_device_id rackmeter_match[] = {
{ .name = "i2s" },
{ }
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v2] macintosh: rack-meter: make of_device_ids const.
2017-06-19 5:44 [PATCH v2] macintosh: rack-meter: make of_device_ids const Arvind Yadav
@ 2017-08-21 13:39 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2017-08-21 13:39 UTC (permalink / raw)
To: Arvind Yadav, benh, mingo; +Cc: linuxppc-dev, linux-kernel
On Mon, 2017-06-19 at 05:44:25 UTC, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 407 576 0 983 3d7 drivers/macintosh/rack-meter.o
>
> File size after constify rackmeter_match.
> text data bss dec hex filename
> 807 176 0 983 3d7 drivers/macintosh/rack-meter.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/516fa8d0e19d854253460ea7692551
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-21 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-19 5:44 [PATCH v2] macintosh: rack-meter: make of_device_ids const Arvind Yadav
2017-08-21 13:39 ` [v2] " Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).