From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xjgLF6JG3zDqV5 for ; Thu, 31 Aug 2017 21:36:05 +1000 (AEST) In-Reply-To: <20170628114907.kf3t65mrdbq7rsfm@mwanda> To: Dan Carpenter , Scott Wood From: Michael Ellerman Cc: kernel-janitors@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: powerpc: remapping too much memory Message-Id: <3xjgLF5Q9Lz9t2W@ozlabs.org> Date: Thu, 31 Aug 2017 21:36:05 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2017-06-28 at 11:49:07 UTC, Dan Carpenter wrote: > There is a cut and paste error here so we use "sizeof(struct mpc83xx_pmc)" > to remap the memory for "clock_regs". That sizeof() is 20 bytes and we > only need to remap 12 bytes. It presumably doesn't affect run time too > much... > > I changed them to both use "sizeof(*variable_name)" because that's the > prefered kernel style these days. > > Fixes: d49747bdfb2d ("powerpc/mpc83xx: Power Management support") > Signed-off-by: Dan Carpenter Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c65540453e150844367ffe98e45d51 cheers