From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Seth Forshee <seth.forshee@canonical.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Shuah Khan <shuah@kernel.org>
Cc: Seth Forshee <seth.forshee@canonical.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: selftests/powerpc: Use snprintf to construct DSCR sysfs interface paths
Date: Sun, 8 Oct 2017 19:43:37 +1100 (AEDT) [thread overview]
Message-ID: <3y8xjj5K9Mz9t5R@ozlabs.org> (raw)
In-Reply-To: <20170928133426.19454-1-seth.forshee@canonical.com>
On Thu, 2017-09-28 at 13:34:26 UTC, Seth Forshee wrote:
> Currently sprintf is used, and while paths should never exceed
> the size of the buffer it is theoretically possible since
> dirent.d_name is 256 bytes. As a result this trips
> -Wformat-overflow, and since the test is built with -Wall -Werror
> the causes the build to fail. Switch to using snprintf and skip
> any paths which are too long for the filename buffer.
>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/06755a871314c7443a89c09650cdb3
cheers
prev parent reply other threads:[~2017-10-08 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 13:34 [PATCH] selftests/powerpc: Use snprintf to construct DSCR sysfs interface paths Seth Forshee
2017-10-08 8:43 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3y8xjj5K9Mz9t5R@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=seth.forshee@canonical.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).