From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Breno Leitao <leitao@debian.org>, linuxppc-dev@lists.ozlabs.org
Cc: Breno Leitao <leitao@debian.org>
Subject: Re: powerpc/xmon: check before calling xive functions
Date: Tue, 24 Oct 2017 19:09:11 +1100 (AEDT) [thread overview]
Message-ID: <3yLmBc0g0lz9sDB@ozlabs.org> (raw)
In-Reply-To: <1508264418-13448-1-git-send-email-leitao@debian.org>
On Tue, 2017-10-17 at 18:20:18 UTC, Breno Leitao wrote:
> Currently xmon could call XIVE functions from OPAL even if the XIVE is
> disabled or does not exist in the system, as in POWER8 machines. This
> causes the following exception:
>
> 1:mon> dx
> cpu 0x1: Vector: 700 (Program Check) at [c000000423c93450]
> pc: c00000000009cfa4: opal_xive_dump+0x50/0x68
> lr: c0000000000997b8: opal_return+0x0/0x50
>
> This patch simply checks if XIVE is enabled before calling XIVE
> functions.
>
> Suggested-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/402e172a2ce76210f2fe921cf419d1
cheers
prev parent reply other threads:[~2017-10-24 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 18:20 [PATCH] powerpc/xmon: check before calling xive functions Breno Leitao
2017-10-18 13:02 ` Michael Ellerman
2017-10-19 7:10 ` Benjamin Herrenschmidt
2017-10-19 13:09 ` Cédric Le Goater
[not found] ` <OF2FDAF97B.BDA3E74C-ON002581BE.004846E4@notes.na.collabserv.com>
2017-10-19 15:21 ` Benjamin Herrenschmidt
2017-10-24 8:09 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3yLmBc0g0lz9sDB@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=leitao@debian.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).