From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [2/2] powerpc/kprobes: Dereference function pointers only if the address does not belong to kernel text
Date: Thu, 2 Nov 2017 23:12:33 +1100 (AEDT) [thread overview]
Message-ID: <3ySP9F58rdz9t34@ozlabs.org> (raw)
In-Reply-To: <6935a132af2cbfe21de0976ad29601b4dd54a4a6.1509374094.git.naveen.n.rao@linux.vnet.ibm.com>
On Mon, 2017-10-30 at 15:12:09 UTC, "Naveen N. Rao" wrote:
> This makes the changes introduced in commit 83e840c770f2c5
> ("powerpc64/elfv1: Only dereference function descriptor for non-text
> symbols") to be specific to the kprobe subsystem.
>
> We previously changed ppc_function_entry() to always check the provided
> address to confirm if it needed to be dereferenced. This is actually
> only an issue for kprobe blacklisted asm labels (through use of
> _ASM_NOKPROBE_SYMBOL) and can cause other issues with ftrace. Also, the
> additional checks are not really necessary for our other uses.
>
> As such, move this check to the kprobes subsystem.
>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/e6c4dcb308160115287afd87afb63b
cheers
prev parent reply other threads:[~2017-11-02 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 15:12 [PATCH 0/2] Fix function_graph tracer for ppc64 BE Naveen N. Rao
2017-10-30 15:12 ` [PATCH 1/2] Revert "powerpc64/elfv1: Only dereference function descriptor for non-text symbols" Naveen N. Rao
2017-11-02 12:12 ` [1/2] " Michael Ellerman
2017-10-30 15:12 ` [PATCH 2/2] powerpc/kprobes: Dereference function pointers only if the address does not belong to kernel text Naveen N. Rao
2017-11-02 12:12 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ySP9F58rdz9t34@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=chandan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).