From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yWlyv02pxzDq78 for ; Wed, 8 Nov 2017 10:30:15 +1100 (AEDT) In-Reply-To: <20171011123020.17594-1-vaibhav@linux.vnet.ibm.com> To: Vaibhav Jain , linuxppc-dev@lists.ozlabs.org, Frederic Barrat From: Michael Ellerman Cc: Philippe Bergheaud , Alastair D'Silva , Vaibhav Jain , Andrew Donnellan , Christophe Lombard Subject: Re: cxl: Rework the implementation of cxl_stop_trace_psl9() Message-Id: <3yWlyt5V5Hz9s7m@ozlabs.org> Date: Wed, 8 Nov 2017 10:30:14 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2017-10-11 at 12:30:20 UTC, Vaibhav Jain wrote: > Presently the PSL9 specific cxl_stop_trace_psl9() only stops the RX0 > traces on the CXL adapter when a PSL error irq is triggered. The patch > updates the function to stop all the traces arrays and move them to > the FIN state. The implementation issues the mmio to TRACECFG register > to stop the trace array iff it already not in FIN state. This prevents > the issue of trace data being reset in case of multiple stop mmio > issued for a single trace array. > > Also the patch does some refactoring of existing cxl_stop_trace_psl9() > and cxl_stop_trace_psl8() functions by moving them to 'pci.c' from > 'debugfs.c' file and marking them as static. > > Signed-off-by: Vaibhav Jain > Acked-by: Frederic Barrat Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/cbb55eeb49b116bb3880137661ad8c cheers