From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: mikey@neuling.org, matt@ozlabs.org
Subject: Re: powerpc/tm: Don't check for WARN in TM Bad Thing handling
Date: Wed, 8 Nov 2017 10:30:14 +1100 (AEDT) [thread overview]
Message-ID: <3yWlyv1TYnz9sNc@ozlabs.org> (raw)
In-Reply-To: <1507783525-28940-1-git-send-email-mpe@ellerman.id.au>
On Thu, 2017-10-12 at 04:45:25 UTC, Michael Ellerman wrote:
> Currently when we take a TM Bad Thing program check exception, we
> search the bug table to see if the program check was generated by a
> WARN/WARN_ON etc.
>
> That makes no sense, the WARN macros use trap instructions, which
> should never generate a TM Bad Thing exception. If they ever did that
> would be a bug and we should oops.
>
> We do have some hand-coded bugs in tm.S, using EMIT_BUG_ENTRY, but
> those are all BUGs not WARNs, and they all use trap instructions
> anyway. Almost certainly this check was incorrectly copied from the
> REASON_TRAP handling in the same function.
>
> Remove it.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Acked-By: Michael Neuling <mikey@neuling.org>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/632f0574167ad3f5d646dad6af87d9
cheers
prev parent reply other threads:[~2017-11-07 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 4:45 [PATCH] powerpc/tm: Don't check for WARN in TM Bad Thing handling Michael Ellerman
2017-10-12 10:47 ` Michael Neuling
2017-11-07 23:30 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3yWlyv1TYnz9sNc@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=matt@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).