From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yWlyx5N3WzDq78 for ; Wed, 8 Nov 2017 10:30:17 +1100 (AEDT) In-Reply-To: <1507783525-28940-1-git-send-email-mpe@ellerman.id.au> To: Michael Ellerman , linuxppc-dev@ozlabs.org From: Michael Ellerman Cc: mikey@neuling.org, matt@ozlabs.org Subject: Re: powerpc/tm: Don't check for WARN in TM Bad Thing handling Message-Id: <3yWlyv1TYnz9sNc@ozlabs.org> Date: Wed, 8 Nov 2017 10:30:14 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2017-10-12 at 04:45:25 UTC, Michael Ellerman wrote: > Currently when we take a TM Bad Thing program check exception, we > search the bug table to see if the program check was generated by a > WARN/WARN_ON etc. > > That makes no sense, the WARN macros use trap instructions, which > should never generate a TM Bad Thing exception. If they ever did that > would be a bug and we should oops. > > We do have some hand-coded bugs in tm.S, using EMIT_BUG_ENTRY, but > those are all BUGs not WARNs, and they all use trap instructions > anyway. Almost certainly this check was incorrectly copied from the > REASON_TRAP handling in the same function. > > Remove it. > > Signed-off-by: Michael Ellerman > Acked-By: Michael Neuling Applied to powerpc next. https://git.kernel.org/powerpc/c/632f0574167ad3f5d646dad6af87d9 cheers