From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [v2, 3/3] powerpc/64s/radix: Fix process table entry cache invalidation
Date: Wed, 8 Nov 2017 10:30:19 +1100 (AEDT) [thread overview]
Message-ID: <3yWlyz3fDyz9t2Z@ozlabs.org> (raw)
In-Reply-To: <20171024130654.1223-4-npiggin@gmail.com>
On Tue, 2017-10-24 at 13:06:54 UTC, Nicholas Piggin wrote:
> According to the architecture, the process table entry cache must be
> flushed with tlbie RIC=2.
>
> Currently the process table entry is set to invalid right before the
> PID is returned to the allocator, with no invalidation. This works on
> existing implementations that are known to not cache the process table
> entry for any except the current PIDR.
>
> It is architecturally correct and cleaner to invalidate with RIC=2
> after clearing the process table entry and before the PID is returned
> to the allocator. This can be done in arch_exit_mmap that runs before
> the final flush, and to ensure the final flush (fullmm) is always a
> RIC=2 variant.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/30b49ec798f0984b905fd94d1957d6
cheers
prev parent reply other threads:[~2017-11-07 23:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 13:06 [PATCH v2 0/3] powerpc/64s/radix: misc minor TLB flush fixes Nicholas Piggin
2017-10-24 13:06 ` [PATCH v2 1/3] powerpc/64s/radix: fix preempt imbalance in TLB flush Nicholas Piggin
2017-10-26 6:52 ` Aneesh Kumar K.V
2017-11-01 5:17 ` [v2,1/3] " Michael Ellerman
2017-10-24 13:06 ` [PATCH v2 2/3] powerpc/64s/radix: tlbie improve preempt handling Nicholas Piggin
2017-10-26 6:53 ` Aneesh Kumar K.V
2017-11-07 23:30 ` [v2,2/3] " Michael Ellerman
2017-10-24 13:06 ` [PATCH v2 3/3] powerpc/64s/radix: Fix process table entry cache invalidation Nicholas Piggin
2017-10-26 6:53 ` Aneesh Kumar K.V
2017-11-07 23:30 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3yWlyz3fDyz9t2Z@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).