From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: David Gibson <david@gibson.dropbear.id.au>, npiggin@gmail.com
Cc: mahesh@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: Revert "powerpc: Do not call ppc_md.panic in fadump panic notifier"
Date: Thu, 7 Dec 2017 00:00:00 +1100 (AEDT) [thread overview]
Message-ID: <3ysJcK4XMCz9sRW@ozlabs.org> (raw)
In-Reply-To: <20171204052725.28195-1-david@gibson.dropbear.id.au>
On Mon, 2017-12-04 at 05:27:25 UTC, David Gibson wrote:
> This reverts commit a3b2cb30f252b21a6f962e0dd107c8b897ca65e4.
>
> The earlier patch tried to fix problems with panic on powerpc in
> certain circumstances, where some output from the generic panic code
> was being dropped.
>
> Unfortunately, it breaks things worse in other circumstances. In
> particular when running a PAPR guest, it will now attempt to reboot
> instead of informing the hypervisor (KVM or PowerVM) that the guest
> has crashed. The crash notification is important to some
> virtualization management layers.
>
> Since the circumstances in which the original patch helped are
> somewhat obscure, revert it for now until we figure out how to do it
> properly.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/ab9dbf771ff9b6b7e814e759213ed0
cheers
prev parent reply other threads:[~2017-12-06 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 5:27 [PATCH] Revert "powerpc: Do not call ppc_md.panic in fadump panic notifier" David Gibson
2017-12-06 13:00 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ysJcK4XMCz9sRW@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).