* [PATCH] powerpc/powermac: drop useless call to of_find_node_by_name
@ 2017-01-31 18:01 Dmitry Torokhov
2017-12-12 11:39 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2017-01-31 18:01 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Paul Mackerras, Michael Ellerman, linuxppc-dev, linux-kernel
We are not using result, so this simply results in a leaked refcount.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Found by visual inspection, not tested...
arch/powerpc/platforms/powermac/feature.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
index 1e02328c3f2d..730e48111848 100644
--- a/arch/powerpc/platforms/powermac/feature.c
+++ b/arch/powerpc/platforms/powermac/feature.c
@@ -2853,7 +2853,6 @@ set_initial_features(void)
}
/* Enable ATA-100 before PCI probe. */
- np = of_find_node_by_name(NULL, "ata-6");
for_each_node_by_name(np, "ata-6") {
if (np->parent
&& of_device_is_compatible(np->parent, "uni-north")
--
2.11.0.483.g087da7b7c-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc/powermac: drop useless call to of_find_node_by_name
2017-01-31 18:01 [PATCH] powerpc/powermac: drop useless call to of_find_node_by_name Dmitry Torokhov
@ 2017-12-12 11:39 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2017-12-12 11:39 UTC (permalink / raw)
To: Dmitry Torokhov, Benjamin Herrenschmidt
Cc: Paul Mackerras, linuxppc-dev, linux-kernel
On Tue, 2017-01-31 at 18:01:44 UTC, Dmitry Torokhov wrote:
> We are not using result, so this simply results in a leaked refcount.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/df26200299eb05fa7d059cd235847e
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-12 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-31 18:01 [PATCH] powerpc/powermac: drop useless call to of_find_node_by_name Dmitry Torokhov
2017-12-12 11:39 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).