From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [2/4] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context
Date: Tue, 12 Dec 2017 22:39:28 +1100 (AEDT) [thread overview]
Message-ID: <3ywyXc72Dlz9t88@ozlabs.org> (raw)
In-Reply-To: <20171116160052.18672-3-npiggin@gmail.com>
On Thu, 2017-11-16 at 16:00:50 UTC, Nicholas Piggin wrote:
> When an interrupt is returning to a soft-disabled context (which can
> happen for non-maskable interrupts or synchronous interrupts), it goes
> through the motions of soft-disabling again, including calling
> TRACE_DISABLE_INTS (i.e., trace_hardirqs_off()).
>
> This is not necessary, because we must already be soft-disabled in the
> interrupt context, it also may be causing crashes in the irq tracing
> code to re-enter as an nmi. Replace it with a warning to ensure that
> soft-interrupts are still disabled.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/acb1feab320e38588fccc568e37677
cheers
next prev parent reply other threads:[~2017-12-12 11:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 16:00 [PATCH 0/4] interrupt tracing fixes Nicholas Piggin
2017-11-16 16:00 ` [PATCH 1/4] powerpc: define __ARCH_IRQ_EXIT_IRQS_DISABLED Nicholas Piggin
2018-01-22 3:34 ` [1/4] " Michael Ellerman
2017-11-16 16:00 ` [PATCH 2/4] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context Nicholas Piggin
2017-12-04 5:09 ` Michael Ellerman
2017-12-04 6:07 ` Nicholas Piggin
2017-12-04 12:55 ` Michael Ellerman
2017-12-04 16:12 ` Benjamin Herrenschmidt
2017-12-05 5:52 ` Michael Ellerman
2017-12-12 11:39 ` Michael Ellerman [this message]
2017-11-16 16:00 ` [PATCH 3/4] cpuidle/powernv: avoid double irq enable coming out of idle Nicholas Piggin
2018-01-22 3:34 ` [3/4] " Michael Ellerman
2017-11-16 16:00 ` [PATCH 4/4] " Nicholas Piggin
2018-01-22 3:34 ` [4/4] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ywyXc72Dlz9t88@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).