From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: powerpc/kernel: Print actual address of regs when oopsing
Date: Thu, 11 Jan 2018 13:25:43 +1100 (AEDT) [thread overview]
Message-ID: <3zH8qq552bz9t3C@ozlabs.org> (raw)
In-Reply-To: <20180111022135.19532-1-mpe@ellerman.id.au>
On Thu, 2018-01-11 at 02:21:35 UTC, Michael Ellerman wrote:
> When we oops or otherwise call show_regs() we print the address of the
> regs structure. Being able to see the address is fairly useful,
> firstly to verify that the regs pointer is not completely bogus, and
> secondly it allows you to dump the regs and surrounding memory with a
> debugger if you have one.
>
> In the normal case the regs will be located somewhere on the stack, so
> printing their location discloses no further information than printing
> the stack pointer does already.
>
> So switch to %px and print the actual address, not the hashed value.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc fixes.
https://git.kernel.org/powerpc/c/182dc9c7f217146d69d9c0b75c150c
cheers
prev parent reply other threads:[~2018-01-11 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 2:21 [PATCH] powerpc/kernel: Print actual address of regs when oopsing Michael Ellerman
2018-01-11 2:25 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3zH8qq552bz9t3C@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).