* [PATCH] powerpc/xive: Properly use static keyword for inline function
@ 2017-12-26 13:00 Mathieu Malaterre
2018-01-15 9:51 ` Cédric Le Goater
2018-01-22 3:34 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2017-12-26 13:00 UTC (permalink / raw)
Cc: Mathieu Malaterre, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Cédric Le Goater, linuxppc-dev,
linux-kernel
Fix fatal warning during compilation:
In file included from arch/powerpc/xmon/xmon.c:54:0:
./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
^
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
arch/powerpc/include/asm/xive.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h
index 371fbebf1ec9..83dc2cc320a3 100644
--- a/arch/powerpc/include/asm/xive.h
+++ b/arch/powerpc/include/asm/xive.h
@@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; }
static inline bool xive_spapr_init(void) { return false; }
static inline bool xive_native_init(void) { return false; }
static inline void xive_smp_probe(void) { }
-extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
+static inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
static inline void xive_smp_setup_cpu(void) { }
static inline void xive_smp_disable_cpu(void) { }
static inline void xive_kexec_teardown_cpu(int secondary) { }
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/xive: Properly use static keyword for inline function
2017-12-26 13:00 [PATCH] powerpc/xive: Properly use static keyword for inline function Mathieu Malaterre
@ 2018-01-15 9:51 ` Cédric Le Goater
2018-01-22 3:34 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2018-01-15 9:51 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev, Linux Kernel Mailing List
On 12/26/2017 02:00 PM, Mathieu Malaterre wrote:
> Fix fatal warning during compilation:
>
> In file included from arch/powerpc/xmon/xmon.c:54:0:
> ./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
> extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
> ^
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> arch/powerpc/include/asm/xive.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h
> index 371fbebf1ec9..83dc2cc320a3 100644
> --- a/arch/powerpc/include/asm/xive.h
> +++ b/arch/powerpc/include/asm/xive.h
> @@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; }
> static inline bool xive_spapr_init(void) { return false; }
> static inline bool xive_native_init(void) { return false; }
> static inline void xive_smp_probe(void) { }
> -extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
> +static inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
> static inline void xive_smp_setup_cpu(void) { }
> static inline void xive_smp_disable_cpu(void) { }
> static inline void xive_kexec_teardown_cpu(int secondary) { }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: powerpc/xive: Properly use static keyword for inline function
2017-12-26 13:00 [PATCH] powerpc/xive: Properly use static keyword for inline function Mathieu Malaterre
2018-01-15 9:51 ` Cédric Le Goater
@ 2018-01-22 3:34 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2018-01-22 3:34 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras,
Cédric Le Goater, linuxppc-dev
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
On Tue, 2017-12-26 at 13:00:17 UTC, Mathieu Malaterre wrote:
> Fix fatal warning during compilation:
>
> In file included from arch/powerpc/xmon/xmon.c:54:0:
> ./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
> extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
> ^
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/38833faa112c10dd6e3d888f8b53de
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-22 3:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-26 13:00 [PATCH] powerpc/xive: Properly use static keyword for inline function Mathieu Malaterre
2018-01-15 9:51 ` Cédric Le Goater
2018-01-22 3:34 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).