linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH kernel] powerpc/powernv/ioda: Finish removing explicit max window size check
@ 2018-01-18  2:51 Alexey Kardashevskiy
  2018-01-22  3:34 ` [kernel] " Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kardashevskiy @ 2018-01-18  2:51 UTC (permalink / raw)
  To: linuxppc-dev
  Cc: Alexey Kardashevskiy, David Gibson, Russell Currey,
	Jonas Pfefferle1

9003a2498 removed checn from the DMA window pages allocator, however
the VFIO driver tests limits before doing so by calling
the get_table_size hook which was left behind; this fixes it.

Fixes: 9003a2498 "powerpc/powernv/ioda: Remove explicit max window size check"
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---

It is properly tested now. Only affected folks for now are DPDK guys
with machines with non-power-of-two physical RAM amount.
---
 arch/powerpc/platforms/powernv/pci-ioda.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
index b9146d5..1069f9c 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
@@ -2572,7 +2572,6 @@ static unsigned long pnv_pci_ioda2_get_table_size(__u32 page_shift,
 	unsigned long direct_table_size;
 
 	if (!levels || (levels > POWERNV_IOMMU_MAX_LEVELS) ||
-			(window_size > memory_hotplug_max()) ||
 			!is_power_of_2(window_size))
 		return 0;
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [kernel] powerpc/powernv/ioda: Finish removing explicit max window size check
  2018-01-18  2:51 [PATCH kernel] powerpc/powernv/ioda: Finish removing explicit max window size check Alexey Kardashevskiy
@ 2018-01-22  3:34 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-01-22  3:34 UTC (permalink / raw)
  To: Alexey Kardashevskiy, linuxppc-dev
  Cc: Alexey Kardashevskiy, Jonas Pfefferle1, David Gibson

On Thu, 2018-01-18 at 02:51:03 UTC, Alexey Kardashevskiy wrote:
> 9003a2498 removed checn from the DMA window pages allocator, however
> the VFIO driver tests limits before doing so by calling
> the get_table_size hook which was left behind; this fixes it.
> 
> Fixes: 9003a2498 "powerpc/powernv/ioda: Remove explicit max window size check"
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/ae677ff02f2ddb0980953efd4afed1

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-22  3:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-18  2:51 [PATCH kernel] powerpc/powernv/ioda: Finish removing explicit max window size check Alexey Kardashevskiy
2018-01-22  3:34 ` [kernel] " Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).