From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zd1Yt2kylzF18d for ; Fri, 9 Feb 2018 15:00:34 +1100 (AEDT) In-Reply-To: <20180130151144.32544-1-colin.king@canonical.com> To: Colin King , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: ocxl: fix signed comparison with less than zero Message-Id: <3zd1Ys6HkGz9sRm@ozlabs.org> Date: Fri, 9 Feb 2018 15:00:33 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2018-01-30 at 15:11:44 UTC, Colin King wrote: > From: Colin Ian King > > Currently the comparison of used < 0 is always false because > uses is a size_t. Fix this by making used a ssize_t type. > > Detected by Coccinelle: > drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression > compared with zero: used < 0 > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Signed-off-by: Colin Ian King > Acked-by: Andrew Donnellan > Acked-by: Frederic Barrat Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/dedab7f0d3137441a97fe7cf9b9ca5 cheers