From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Rob Herring <robh@kernel.org>,
Alistair Popple <alistair@popple.id.au>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [kernel] powerpc/pci: Fix broken INTx configuration via OF
Date: Fri, 9 Feb 2018 15:00:36 +1100 (AEDT) [thread overview]
Message-ID: <3zd1Yw5kRtz9t3C@ozlabs.org> (raw)
In-Reply-To: <20180208053354.41725-1-aik@ozlabs.ru>
On Thu, 2018-02-08 at 05:33:54 UTC, Alexey Kardashevskiy wrote:
> Commit 59f47eff03a0 ("powerpc/pci: Use of_irq_parse_and_map_pci() helper")
> correctly states that of_irq_parse_and_map_pci() does the same thing as
> of_irq_parse_pci() does as it simply calls
> of_irq_parse_pci() and irq_create_of_mapping().
>
> However of_irq_parse_and_map_pci() not only returns 0 for success and
> negative value for an error but also a positive virq value from
> irq_create_of_mapping() which the mentioned commit ignores and
> INTx config fails.
>
> This fixes the of_irq_parse_and_map_pci() return value handling.
>
> Fixes: 59f47eff03a0 "powerpc/pci: Use of_irq_parse_and_map_pci() helper"
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/560c0f978155282e36f33d21b2aeae
cheers
next prev parent reply other threads:[~2018-02-09 4:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 5:33 [PATCH kernel] powerpc/pci: Fix broken INTx configuration via OF Alexey Kardashevskiy
2018-02-08 19:20 ` Bjorn Helgaas
2018-02-08 21:39 ` Bjorn Helgaas
2018-02-08 22:21 ` Benjamin Herrenschmidt
2018-02-08 22:42 ` Bjorn Helgaas
2018-02-08 22:50 ` Benjamin Herrenschmidt
2018-02-08 19:46 ` Rob Herring
2018-02-09 4:00 ` Michael Ellerman [this message]
2018-02-09 4:20 ` [kernel] " Alexey Kardashevskiy
2018-02-09 5:34 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3zd1Yw5kRtz9t3C@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=alistair@popple.id.au \
--cc=bhelgaas@google.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).