From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
benh@kernel.crashing.org, paulus@samba.org,
Ram Pai <linuxram@us.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [V2,1/4] powerpc/mm: Fix crashes with PUD level hugetlb config
Date: Wed, 14 Feb 2018 16:43:46 +1100 (AEDT) [thread overview]
Message-ID: <3zh7cf2sx1z9t3M@ozlabs.org> (raw)
In-Reply-To: <20180211150009.21297-1-aneesh.kumar@linux.vnet.ibm.com>
On Sun, 2018-02-11 at 15:00:06 UTC, "Aneesh Kumar K.V" wrote:
> To support memory keys, we moved the hash pte slot information to the second
> half of the page table. This was ok with PTE entries at level 4 and level 3.
> We already allocate larger page table pages at those level to accomodate extra
> details. For level 4 we already have the extra space which was used to track
> 4k hash page table entry details and at pmd level the extra space was allocated
> to track the THP details.
>
> With hugetlbfs PTE, we used this extra space at the PMD level to store the
> slot details. But we also support hugetlbfs PTE at PUD leve and PUD level page
> didn't allocate extra space. This resulted in memory corruption.
>
> Fix this by allocating extra space at PUD level when HUGETLB is enabled. We
> may need further changes to allocate larger space at PMD level when we enable
> HUGETLB. That will be done in next patch.
>
> Fixes:bf9a95f9a6481bc6e(" powerpc: Free up four 64K PTE bits in 64K backed HPTE pages")
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Reviewed-by: Ram Pai <linuxram@us.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/fae2211697c9490414e974431051f7
cheers
prev parent reply other threads:[~2018-02-14 5:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 15:00 [PATCH V2 1/4] powerpc/mm: Fix crashes with PUD level hugetlb config Aneesh Kumar K.V
2018-02-11 15:00 ` [PATCH V2 2/4] powerpc/mm/hash64: Allocate larger PMD table if hugetlb config is enabled Aneesh Kumar K.V
2018-02-11 22:28 ` Ram Pai
2018-02-14 5:43 ` [V2, " Michael Ellerman
2018-02-11 15:00 ` [PATCH V2 3/4] powerpc/mm/hash64: Store the slot information at the right offset Aneesh Kumar K.V
2018-02-11 22:39 ` Ram Pai
2018-02-14 5:43 ` [V2, " Michael Ellerman
2018-02-11 15:00 ` [PATCH V2 4/4] powerpc/mm/hash64: memset the pagetable pages on allocation Aneesh Kumar K.V
2018-02-11 22:24 ` [PATCH V2 1/4] powerpc/mm: Fix crashes with PUD level hugetlb config Ram Pai
2018-02-14 5:43 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3zh7cf2sx1z9t3M@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).