From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Guenter Roeck <linux@roeck-us.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org,
Michael Bringmann <mwb@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [2/2] powerpc/pseries: Declare optional dummy function for find_and_online_cpu_nid
Date: Wed, 14 Feb 2018 16:43:48 +1100 (AEDT) [thread overview]
Message-ID: <3zh7ch49bHz9t6D@ozlabs.org> (raw)
In-Reply-To: <1518474848-3158-2-git-send-email-linux@roeck-us.net>
On Mon, 2018-02-12 at 22:34:08 UTC, Guenter Roeck wrote:
> Commit e67e02a544e9 ("powerpc/pseries: Fix cpu hotplug crash with
> memoryless nodes") adds an unconditional call to find_and_online_cpu_nid(),
> which is only declared if CONFIG_PPC_SPLPAR is enabled. This results in
> the following build error if this is not the case.
>
> arch/powerpc/platforms/pseries/hotplug-cpu.o: In function `dlpar_online_cpu':
> arch/powerpc/platforms/pseries/hotplug-cpu.c:369:
> undefined reference to `.find_and_online_cpu_nid'
>
> Follow the guideline provided by similar functions and provide a dummy
> function if CONFIG_PPC_SPLPAR is not enabled. This also moves the external
> function declaration into an include file where it should be.
>
> Fixes: e67e02a544e9 ("powerpc/pseries: Fix cpu hotplug crash with ...")
> Cc: Michael Bringmann <mwb@linux.vnet.ibm.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/82343484a2d4c97a03bfd81303b549
cheers
next prev parent reply other threads:[~2018-02-14 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 22:34 [PATCH 1/2] powerpc/kdump: Add missing optional dummy functions Guenter Roeck
2018-02-12 22:34 ` [PATCH 2/2] powerpc/pseries: Declare optional dummy function for find_and_online_cpu_nid Guenter Roeck
2018-02-13 19:49 ` Tyrel Datwyler
2018-02-14 5:43 ` Michael Ellerman [this message]
2018-02-12 23:01 ` [PATCH 1/2] powerpc/kdump: Add missing optional dummy functions Balbir Singh
2018-02-12 23:25 ` Guenter Roeck
2018-02-14 2:32 ` Balbir Singh
2018-02-13 11:49 ` Michael Ellerman
2018-02-14 5:43 ` [1/2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3zh7ch49bHz9t6D@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mwb@linux.vnet.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).