* [PATCH] powerpc: add empty update_numa_cpu_lookup_table for !CONFIG_NUMA
@ 2018-02-14 12:17 Corentin Labbe
2018-02-18 8:55 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2018-02-14 12:17 UTC (permalink / raw)
To: benh, mpe, paulus, nfont, tyreld
Cc: linux-kernel, linuxppc-dev, Corentin Labbe
When CONFIG_NUMA is not set, build fail with:
arch/powerpc/platforms/pseries/hotplug-cpu.c:335:4: error: déclaration implicite de la fonction « update_numa_cpu_lookup_table » [-Werror=implicit-function-declaration]
So we have to add update_numa_cpu_lookup_table as an empty function when CONFIG_NUMA is not set.
Fixes: 1d9a090783be ("powerpc/numa: Invalidate numa_cpu_lookup_table on cpu remove")
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
arch/powerpc/include/asm/topology.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/include/asm/topology.h b/arch/powerpc/include/asm/topology.h
index 593248110902..9f421641a35c 100644
--- a/arch/powerpc/include/asm/topology.h
+++ b/arch/powerpc/include/asm/topology.h
@@ -81,6 +81,9 @@ static inline int numa_update_cpu_topology(bool cpus_locked)
{
return 0;
}
+
+static inline void update_numa_cpu_lookup_table(unsigned int cpu, int node) {}
+
#endif /* CONFIG_NUMA */
#if defined(CONFIG_NUMA) && defined(CONFIG_PPC_SPLPAR)
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc: add empty update_numa_cpu_lookup_table for !CONFIG_NUMA
2018-02-14 12:17 [PATCH] powerpc: add empty update_numa_cpu_lookup_table for !CONFIG_NUMA Corentin Labbe
@ 2018-02-18 8:55 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-02-18 8:55 UTC (permalink / raw)
To: Corentin Labbe, benh, paulus, nfont, tyreld
Cc: linuxppc-dev, linux-kernel, Corentin Labbe
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
On Wed, 2018-02-14 at 12:17:47 UTC, Corentin Labbe wrote:
> When CONFIG_NUMA is not set, build fail with:
> arch/powerpc/platforms/pseries/hotplug-cpu.c:335:4: error: déclaration implicite de la fonction « update_numa_cpu_lookup_table » [-Werror=implicit-function-declaration]
>
> So we have to add update_numa_cpu_lookup_table as an empty function when CONFIG_NUMA is not set.
>
> Fixes: 1d9a090783be ("powerpc/numa: Invalidate numa_cpu_lookup_table on cpu remove")
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/c1e150ceb61e4a585bad156da15c33
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-18 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-14 12:17 [PATCH] powerpc: add empty update_numa_cpu_lookup_table for !CONFIG_NUMA Corentin Labbe
2018-02-18 8:55 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).