From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc: Keep const vars out of writable .sdata
Date: Wed, 7 Mar 2018 00:31:17 +1100 (AEDT) [thread overview]
Message-ID: <3zwd2v0v8nz9shN@ozlabs.org> (raw)
In-Reply-To: <20180301010249.GA18370@beast>
On Thu, 2018-03-01 at 01:02:49 UTC, Kees Cook wrote:
> From: Segher Boessenkool <segher@kernel.crashing.org>
>
> Newer gcc will support "-mno-readonly-in-sdata"[1], which makes sure that
> the optimization on PPC32 for variables getting moved into the .sdata
> section will not apply to const variables (which must be in .rodata).
>
> This was originally noticed in mm/rodata_test.c when rodata_test_data
> was not static:
>
> c0695034 g O .data 00000004 rodata_test_data
>
> After this patch with an updated compiler, this is correctly in .rodata.
>
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82411
>
> Reported-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/51d42f0f5fd6c74144d19bf6a66352
cheers
prev parent reply other threads:[~2018-03-06 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 1:02 [PATCH] powerpc: Keep const vars out of writable .sdata Kees Cook
2018-03-06 13:31 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3zwd2v0v8nz9shN@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).