From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "Cédric Le Goater" <clg@kaod.org>, linuxppc-dev@lists.ozlabs.org
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH 13/23] powerpc/mm: Move hpte_insert_repeating() prototype
Date: Mon, 21 Dec 2020 09:16:08 +0100 [thread overview]
Message-ID: <40284fdb-12ce-fdb2-f1f5-7df803c226e9@csgroup.eu> (raw)
In-Reply-To: <20201221074222.403894-14-clg@kaod.org>
Le 21/12/2020 à 08:42, Cédric Le Goater a écrit :
> It fixes this W=1 compile error :
>
> ../arch/powerpc/mm/book3s64/hash_utils.c:1867:6: error: no previous prototype for ‘hpte_insert_repeating’ [-Werror=missing-prototypes]
> 1867 | long hpte_insert_repeating(unsigned long hash, unsigned long vpn,
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> arch/powerpc/include/asm/book3s/64/mmu-hash.h | 5 +++++
> arch/powerpc/mm/book3s64/hash_hugetlbpage.c | 4 ----
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
> index a94fd4e0c182..76ff95950309 100644
> --- a/arch/powerpc/include/asm/book3s/64/mmu-hash.h
> +++ b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
> @@ -454,6 +454,11 @@ static inline unsigned long hpt_hash(unsigned long vpn,
> #define HPTE_NOHPTE_UPDATE 0x2
> #define HPTE_USE_KERNEL_KEY 0x4
>
> +extern long hpte_insert_repeating(unsigned long hash, unsigned long vpn,
> + unsigned long pa, unsigned long rlags,
> + unsigned long vflags, int psize, int ssize);
> +
> +
Don't copy the 'extern' keyword. It is useless for function prototypes.
Then you could probably fit on only two lines (nowadays 100 chars are allowed per line)
> extern int __hash_page_4K(unsigned long ea, unsigned long access,
> unsigned long vsid, pte_t *ptep, unsigned long trap,
> unsigned long flags, int ssize, int subpage_prot);
> diff --git a/arch/powerpc/mm/book3s64/hash_hugetlbpage.c b/arch/powerpc/mm/book3s64/hash_hugetlbpage.c
> index b5e9fff8c217..a688e1324ae5 100644
> --- a/arch/powerpc/mm/book3s64/hash_hugetlbpage.c
> +++ b/arch/powerpc/mm/book3s64/hash_hugetlbpage.c
> @@ -16,10 +16,6 @@
> unsigned int hpage_shift;
> EXPORT_SYMBOL(hpage_shift);
>
> -extern long hpte_insert_repeating(unsigned long hash, unsigned long vpn,
> - unsigned long pa, unsigned long rlags,
> - unsigned long vflags, int psize, int ssize);
> -
> int __hash_page_huge(unsigned long ea, unsigned long access, unsigned long vsid,
> pte_t *ptep, unsigned long trap, unsigned long flags,
> int ssize, unsigned int shift, unsigned int mmu_psize)
>
next prev parent reply other threads:[~2020-12-21 8:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 7:41 [PATCH 00/23] powerpc: Fix W=1 compile errors Cédric Le Goater
2020-12-21 7:42 ` [PATCH 01/23] powerpc/mm: Include __find_linux_pte() prototype Cédric Le Goater
2020-12-21 7:42 ` [PATCH 02/23] powerpc/pseries/ras: Remove unused variable 'status' Cédric Le Goater
2020-12-21 8:06 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 03/23] powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static Cédric Le Goater
2020-12-21 8:07 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 04/23] powerpc/pseries/ras: Make init_ras_hotplug_IRQ() static Cédric Le Goater
2020-12-21 8:07 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 05/23] powerpc/pmem: Include pmem prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 06/23] powerpc/setup_64: Make some routines static Cédric Le Goater
2020-12-21 8:08 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 07/23] powerpc/mce: Include prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 08/23] powerpc/smp: Include tick_broadcast() prototype Cédric Le Goater
2020-12-21 7:42 ` [PATCH 09/23] powerpc/smp: Make debugger_ipi_callback() static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 10/23] powerpc/optprobes: Remove unused routine patch_imm32_load_insns() Cédric Le Goater
2020-12-21 8:14 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 11/23] powerpc/optprobes: Make patch_imm64_load_insns() static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 12/23] powerpc/mm: Declare some prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 13/23] powerpc/mm: Move hpte_insert_repeating() prototype Cédric Le Goater
2020-12-21 8:16 ` Christophe Leroy [this message]
2020-12-21 7:42 ` [PATCH 14/23] powerpc/mm: Declare preload_new_slb_context() prototype Cédric Le Goater
2020-12-21 7:42 ` [PATCH 15/23] powerpc/mm/hugetlb: Make pseries_alloc_bootmem_huge_page() static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 16/23] powerpc/mm: Declare arch_report_meminfo() prototype Cédric Le Goater
2020-12-21 7:42 ` [PATCH 17/23] powerpc/watchdog: Declare soft_nmi_interrupt() prototype Cédric Le Goater
2020-12-21 8:48 ` Christophe Leroy
2021-01-04 14:03 ` Cédric Le Goater
2020-12-21 7:42 ` [PATCH 18/23] KVM: PPC: Make the VMX instruction emulation routines static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 19/23] KVM: PPC: Book3S HV: Include prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 20/23] KVM: PPC: Book3S HV: Declare some prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 21/23] powerpc/pseries: Make IOV setup routines static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 22/23] powerpc/pcidn: " Cédric Le Goater
2020-12-21 7:42 ` [PATCH 23/23] powerpc/pseries/eeh: Make pseries_send_allow_unfreeze() static Cédric Le Goater
2020-12-21 8:49 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40284fdb-12ce-fdb2-f1f5-7df803c226e9@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=aneesh.kumar@linux.ibm.com \
--cc=clg@kaod.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).