From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA63C433DB for ; Mon, 21 Dec 2020 08:34:13 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90D4C22BED for ; Mon, 21 Dec 2020 08:34:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90D4C22BED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Czt6p5WtYzDqBN for ; Mon, 21 Dec 2020 19:34:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CzskM5CgpzDqM3 for ; Mon, 21 Dec 2020 19:16:26 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4CzskB0XYvzB09ZX; Mon, 21 Dec 2020 09:16:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id z84Cu6KYnQQj; Mon, 21 Dec 2020 09:16:18 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Czsk96QdNzB09ZW; Mon, 21 Dec 2020 09:16:17 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E42178B7BE; Mon, 21 Dec 2020 09:16:22 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 1CskhB0VnZ9H; Mon, 21 Dec 2020 09:16:22 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 907B08B7C7; Mon, 21 Dec 2020 09:16:22 +0100 (CET) Subject: Re: [PATCH 13/23] powerpc/mm: Move hpte_insert_repeating() prototype To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , linuxppc-dev@lists.ozlabs.org References: <20201221074222.403894-1-clg@kaod.org> <20201221074222.403894-14-clg@kaod.org> From: Christophe Leroy Message-ID: <40284fdb-12ce-fdb2-f1f5-7df803c226e9@csgroup.eu> Date: Mon, 21 Dec 2020 09:16:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201221074222.403894-14-clg@kaod.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Aneesh Kumar K.V" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 21/12/2020 à 08:42, Cédric Le Goater a écrit : > It fixes this W=1 compile error : > > ../arch/powerpc/mm/book3s64/hash_utils.c:1867:6: error: no previous prototype for ‘hpte_insert_repeating’ [-Werror=missing-prototypes] > 1867 | long hpte_insert_repeating(unsigned long hash, unsigned long vpn, > | ^~~~~~~~~~~~~~~~~~~~~ > > Cc: "Aneesh Kumar K.V" > Signed-off-by: Cédric Le Goater > --- > arch/powerpc/include/asm/book3s/64/mmu-hash.h | 5 +++++ > arch/powerpc/mm/book3s64/hash_hugetlbpage.c | 4 ---- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h b/arch/powerpc/include/asm/book3s/64/mmu-hash.h > index a94fd4e0c182..76ff95950309 100644 > --- a/arch/powerpc/include/asm/book3s/64/mmu-hash.h > +++ b/arch/powerpc/include/asm/book3s/64/mmu-hash.h > @@ -454,6 +454,11 @@ static inline unsigned long hpt_hash(unsigned long vpn, > #define HPTE_NOHPTE_UPDATE 0x2 > #define HPTE_USE_KERNEL_KEY 0x4 > > +extern long hpte_insert_repeating(unsigned long hash, unsigned long vpn, > + unsigned long pa, unsigned long rlags, > + unsigned long vflags, int psize, int ssize); > + > + Don't copy the 'extern' keyword. It is useless for function prototypes. Then you could probably fit on only two lines (nowadays 100 chars are allowed per line) > extern int __hash_page_4K(unsigned long ea, unsigned long access, > unsigned long vsid, pte_t *ptep, unsigned long trap, > unsigned long flags, int ssize, int subpage_prot); > diff --git a/arch/powerpc/mm/book3s64/hash_hugetlbpage.c b/arch/powerpc/mm/book3s64/hash_hugetlbpage.c > index b5e9fff8c217..a688e1324ae5 100644 > --- a/arch/powerpc/mm/book3s64/hash_hugetlbpage.c > +++ b/arch/powerpc/mm/book3s64/hash_hugetlbpage.c > @@ -16,10 +16,6 @@ > unsigned int hpage_shift; > EXPORT_SYMBOL(hpage_shift); > > -extern long hpte_insert_repeating(unsigned long hash, unsigned long vpn, > - unsigned long pa, unsigned long rlags, > - unsigned long vflags, int psize, int ssize); > - > int __hash_page_huge(unsigned long ea, unsigned long access, unsigned long vsid, > pte_t *ptep, unsigned long trap, unsigned long flags, > int ssize, unsigned int shift, unsigned int mmu_psize) >