From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jordan Niethe <jniethe5@gmail.com>, linuxppc-dev@ozlabs.org
Cc: alistair@popple.id.au
Subject: Re: [PATCH 3/4] powerpc: Handle prefixed instructions in show_user_instructions()
Date: Tue, 22 Feb 2022 15:34:33 +0100 [thread overview]
Message-ID: <4029503f-dbc4-cb68-5f40-771e8d0bfbc6@csgroup.eu> (raw)
In-Reply-To: <20200602052728.18227-3-jniethe5@gmail.com>
Le 02/06/2020 à 07:27, Jordan Niethe a écrit :
> Currently prefixed instructions are treated as two word instructions by
> show_user_instructions(), treat them as a single instruction. '<' and
> '>' are placed around the instruction at the NIP, and for prefixed
> instructions this is placed around the prefix only. Make the '<' and '>'
> wrap the prefix and suffix.
>
> Currently showing a prefixed instruction looks like:
> fbe1fff8 39200000 06000000 a3e30000 <04000000> f7e40000 ebe1fff8 4e800020
>
> Make it look like:
> 0xfbe1fff8 0x39200000 0x06000000 0xa3e30000 <0x04000000 0xf7e40000> 0xebe1fff8 0x4e800020 0x00000000 0x00000000
Is it really needed to have the leading 0x ?
And is there a reason for that two 0x00000000 at the end of the new line
that we don't have at the end of the old line ?
This is initially split into 8 instructions per line in order to fit in
a 80 columns screen/terminal.
Could you make it such that it still fits within 80 cols ?
Same for patch 4 on show_user_instructions()
Christophe
next prev parent reply other threads:[~2022-02-22 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 5:27 [PATCH 1/4] powerpc: Add a ppc_inst_as_str() helper Jordan Niethe
2020-06-02 5:27 ` [PATCH 2/4] powerpc/xmon: Improve dumping prefixed instructions Jordan Niethe
2020-06-02 5:27 ` [PATCH 3/4] powerpc: Handle prefixed instructions in show_user_instructions() Jordan Niethe
2022-02-22 14:34 ` Christophe Leroy [this message]
2022-03-14 23:00 ` Jordan Niethe
2020-06-02 5:27 ` [PATCH 4/4] powerpc: Handle prefixed instructions in show_instructions() Jordan Niethe
2020-06-02 7:43 ` [PATCH 1/4] powerpc: Add a ppc_inst_as_str() helper Joel Stanley
2020-06-02 19:41 ` Segher Boessenkool
2020-07-24 13:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4029503f-dbc4-cb68-5f40-771e8d0bfbc6@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=alistair@popple.id.au \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).