From: Nikhil Kumar Singh <nikhilks@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] PCI: pnv_php: Add null checks for OpenCAPI PHBs
Date: Wed, 15 Jul 2026 00:38:38 +0530 [thread overview]
Message-ID: <404f6d27-db62-4a21-b364-4c312eb28f87@linux.ibm.com> (raw)
In-Reply-To: <20260609084903.1352581-1-adityag@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
Hi Aditya,
The added NULL checks for OpenCAPI/direct PHB slots make sense. The
patch looks overall good to me but I have one question about below change:
On 09/06/26 14:19, Aditya Gupta wrote:
> + if (!bridge) {
> + *state = 0;
> + return 0;
> + }
> +
Is returning success with an indicator state of 0 the expected behaviour
for slots without a bridge, or would returning an error such as
-EOPNOTSUPP(Operation Not Supported) or -ENODEV(No Such Device) be more
appropriate?
Thanks,
~ Nikhil
[-- Attachment #2: Type: text/html, Size: 985 bytes --]
prev parent reply other threads:[~2026-07-14 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 8:49 [PATCH v3] PCI: pnv_php: Add null checks for OpenCAPI PHBs Aditya Gupta
2026-07-14 19:08 ` Nikhil Kumar Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404f6d27-db62-4a21-b364-4c312eb28f87@linux.ibm.com \
--to=nikhilks@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox