linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc/perf: Give generic PMU a nice name
Date: Tue, 31 May 2022 14:23:17 +0530	[thread overview]
Message-ID: <407cd655-748e-a276-4c2b-d214a33f8981@linux.ibm.com> (raw)
In-Reply-To: <20220526063723.51471-1-joel@jms.id.au>


On 5/26/22 12:07 PM, Joel Stanley wrote:
> When booting on a machine that uses the compat pmu driver we see this:
>
>   [    0.071192] GENERIC_COMPAT performance monitor hardware support registered
Sorry that was my mistake.
I agree having it as ISAv3 is better.

Maddy

>
> Which is a bit shouty. Give it a nicer name.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>
> Other options:
>
>   - ISAv3 (because it is relevant for PowerISA 3.0B and beyond, see the
>     comment in init_generic_compat_pmu)
>
>   - Generic Compat (same, but less shouty)
>
>   arch/powerpc/perf/generic-compat-pmu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/perf/generic-compat-pmu.c b/arch/powerpc/perf/generic-compat-pmu.c
> index f3db88aee4dd..5be5a5ebaf42 100644
> --- a/arch/powerpc/perf/generic-compat-pmu.c
> +++ b/arch/powerpc/perf/generic-compat-pmu.c
> @@ -292,7 +292,7 @@ static int generic_compute_mmcr(u64 event[], int n_ev,
>   }
>   
>   static struct power_pmu generic_compat_pmu = {
> -	.name			= "GENERIC_COMPAT",
> +	.name			= "Architected",
>   	.n_counter		= MAX_PMU_COUNTERS,
>   	.add_fields		= ISA207_ADD_FIELDS,
>   	.test_adder		= ISA207_TEST_ADDER,

  reply	other threads:[~2022-05-31  8:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  6:37 [PATCH] powerpc/perf: Give generic PMU a nice name Joel Stanley
2022-05-31  8:53 ` Madhavan Srinivasan [this message]
2022-06-10  4:36   ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=407cd655-748e-a276-4c2b-d214a33f8981@linux.ibm.com \
    --to=maddy@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).