From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40B8xL15XpzF2MD for ; Thu, 29 Mar 2018 01:13:26 +1100 (AEDT) In-Reply-To: To: Sam Bobroff , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [v2,1/9] powerpc/eeh: Remove eeh_handle_event() Message-Id: <40B8xK5LGpz9s12@ozlabs.org> Date: Thu, 29 Mar 2018 01:13:25 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2018-03-19 at 02:46:20 UTC, Sam Bobroff wrote: > The function eeh_handle_event(pe) does nothing other than switching > between calling eeh_handle_normal_event(pe) and > eeh_handle_special_event(). However it is only called in two places, > one where pe can't be NULL and the other where it must be NULL (see > eeh_event_handler()) so it does nothing but obscure the flow of > control. > > So, remove it. > > Signed-off-by: Sam Bobroff > Reviewed-by: Alexey Kardashevskiy Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/68701780712f7ddb2fa81032aa1b4a cheers