From: "Mark A. Greer" <mgreer@mvista.com>
To: Adrian Cox <adrian@humboldt.co.uk>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH][RFC] OCP support for MPC107 and relatives
Date: Mon, 14 Jun 2004 10:05:11 -0700 [thread overview]
Message-ID: <40CDDAC7.4090608@mvista.com> (raw)
In-Reply-To: <1087207803.7360.83.camel@newt>
Adrian Cox wrote:
> <snip>
>
>- if (host_bridge != MPC10X_BRIDGE_106) {
>+ if (host_bridge == MPC10X_BRIDGE_106) {
>+ /* On-chip peripherals were introduced with the MPC107/MPC8240 */
>+ core_ocp[0].vendor = OCP_VENDOR_INVALID;
>
><snip>
>
> OpenPIC_Addr =
> ioremap(phys_eumb_base + MPC10X_EUMB_EPIC_OFFSET,
> MPC10X_EUMB_EPIC_SIZE);
>+#endif
>+ core_ocp[0].paddr = phys_eumb_base + MPC10X_EUMB_I2C_OFFSET;
> }
>
>
That's great that you're OCP-ifying the mpc10x code! My only comment is
thatI don't like hardcoding the position of an entry in the OCP (e.g.,
core_ocp[0].vedor/paddr). I don't think its safe to assume that any
particular piece of code will always know all of the entries in the OCP
and therefore what an entry's position will be. You can use
'ocp_for_each_device()' and a routine that checks for the fields that
you want to accomplish the same thing.
Mark
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-06-14 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-14 10:10 [PATCH][RFC] OCP support for MPC107 and relatives Adrian Cox
2004-06-14 10:23 ` [PATCH][RFC] I2C " Adrian Cox
2004-06-14 11:01 ` Stefan Nickl
2004-06-14 11:37 ` Adrian Cox
2004-06-14 13:01 ` Stefan Nickl
2004-06-14 13:24 ` Adrian Cox
2004-06-14 13:39 ` Kumar Gala
2004-06-14 14:38 ` Pantelis Antoniou
2004-06-14 13:43 ` [PATCH][RFC] OCP " Kumar Gala
2004-06-14 13:59 ` Kumar Gala
2004-06-14 14:47 ` Adrian Cox
2004-06-14 15:46 ` Matt Porter
2004-06-15 0:38 ` Kumar Gala
2004-06-14 17:05 ` Mark A. Greer [this message]
2004-06-15 8:10 ` Adrian Cox
2004-06-15 17:33 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40CDDAC7.4090608@mvista.com \
--to=mgreer@mvista.com \
--cc=adrian@humboldt.co.uk \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).