From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-gpio@vger.kernel.org, "Paul Mackerras" <paulus@samba.org>,
"Joel Stanley" <joel@jms.id.au>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [v3, 1/4] powerpc: wii: Explicitly configure GPIO owner for poweroff pin
Date: Sun, 1 Apr 2018 01:03:45 +1100 (AEDT) [thread overview]
Message-ID: <40D0Zr5ldZz9s2b@ozlabs.org> (raw)
In-Reply-To: <20180209120732.17863-2-j.neuschaefer@gmx.net>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
On Fri, 2018-02-09 at 12:07:28 UTC, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= wrote:
> The Hollywood chipset's GPIO controller has two sets of registers: One
> for access by the PowerPC CPU, and one for access by the ARM coprocessor
> (but both are accessible from the PPC because the memory firewall
> (AHBPROT) is usually disabled when booting Linux, today).
>
> The wii_power_off function currently assumes that the poweroff GPIO pin
> is configured for use via the ARM side, but the upcoming GPIO driver
> configures all pins for use via the PPC side, breaking poweroff.
>
> Configure the owner register explicitly in wii_power_off to make
> wii_power_off work with and without the new GPIO driver.
>
> I think the Wii can be switched to the generic gpio-poweroff driver,
> after the GPIO driver is merged.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Patches 1, 3 and 4 applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/9cbaaec1cf0c9f4861c4c1dd65f3ed
cheers
next prev parent reply other threads:[~2018-03-31 14:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 12:07 [PATCH v3 0/4] Nintendo Wii GPIO driver Jonathan Neuschäfer
2018-02-09 12:07 ` [PATCH v3 1/4] powerpc: wii: Explicitly configure GPIO owner for poweroff pin Jonathan Neuschäfer
2018-03-31 14:03 ` Michael Ellerman [this message]
2018-02-09 12:07 ` [PATCH v3 2/4] gpio: Add GPIO driver for Nintendo Wii Jonathan Neuschäfer
2018-02-09 15:11 ` Segher Boessenkool
2018-02-09 15:30 ` Andy Shevchenko
2018-02-09 16:58 ` Jonathan Neuschäfer
2018-02-09 15:48 ` Jonathan Neuschäfer
2018-02-22 12:57 ` Linus Walleij
2018-02-22 13:08 ` Jonathan Neuschäfer
2018-02-09 12:07 ` [PATCH v3 3/4] powerpc: wii.dts: Add ngpios property Jonathan Neuschäfer
2018-02-09 12:07 ` [PATCH v3 4/4] powerpc: wii.dts: Add GPIO line names Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D0Zr5ldZz9s2b@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).