From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
PowerPC <linuxppc-dev@lists.ozlabs.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: drivers: macintosh: rack-meter: really fix bogus memsets
Date: Sun, 1 Apr 2018 01:03:54 +1100 (AEDT) [thread overview]
Message-ID: <40D0b24Gsdz9s33@ozlabs.org> (raw)
In-Reply-To: <20180316201728.3377-1-aaro.koskinen@iki.fi>
On Fri, 2018-03-16 at 20:17:28 UTC, Aaro Koskinen wrote:
> We should zero an array using sizeof instead of number of elements.
>
> Fixes the following compiler (GCC 7.3.0) warnings:
>
> drivers/macintosh/rack-meter.c: In function 'rackmeter_do_pause':
> drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
> drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
>
> Fixes: 4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e283655b5abe26462d53d5196f186c
cheers
prev parent reply other threads:[~2018-03-31 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 20:17 [PATCH] drivers: macintosh: rack-meter: really fix bogus memsets Aaro Koskinen
2018-03-31 14:03 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D0b24Gsdz9s33@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aaro.koskinen@iki.fi \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).