* [PATCH] drivers: macintosh: rack-meter: really fix bogus memsets
@ 2018-03-16 20:17 Aaro Koskinen
2018-03-31 14:03 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2018-03-16 20:17 UTC (permalink / raw)
To: PowerPC, Stephen Rothwell, Michael Ellerman,
Benjamin Herrenschmidt
Cc: Aaro Koskinen
We should zero an array using sizeof instead of number of elements.
Fixes the following compiler (GCC 7.3.0) warnings:
drivers/macintosh/rack-meter.c: In function 'rackmeter_do_pause':
drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
Fixes: 4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/macintosh/rack-meter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c
index 910b5b6..eb65b6e 100644
--- a/drivers/macintosh/rack-meter.c
+++ b/drivers/macintosh/rack-meter.c
@@ -154,8 +154,8 @@ static void rackmeter_do_pause(struct rackmeter *rm, int pause)
DBDMA_DO_STOP(rm->dma_regs);
return;
}
- memset(rdma->buf1, 0, ARRAY_SIZE(rdma->buf1));
- memset(rdma->buf2, 0, ARRAY_SIZE(rdma->buf2));
+ memset(rdma->buf1, 0, sizeof(rdma->buf1));
+ memset(rdma->buf2, 0, sizeof(rdma->buf2));
rm->dma_buf_v->mark = 0;
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: drivers: macintosh: rack-meter: really fix bogus memsets
2018-03-16 20:17 [PATCH] drivers: macintosh: rack-meter: really fix bogus memsets Aaro Koskinen
@ 2018-03-31 14:03 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-03-31 14:03 UTC (permalink / raw)
To: Aaro Koskinen, PowerPC, Stephen Rothwell, Benjamin Herrenschmidt
Cc: Aaro Koskinen
On Fri, 2018-03-16 at 20:17:28 UTC, Aaro Koskinen wrote:
> We should zero an array using sizeof instead of number of elements.
>
> Fixes the following compiler (GCC 7.3.0) warnings:
>
> drivers/macintosh/rack-meter.c: In function 'rackmeter_do_pause':
> drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
> drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
>
> Fixes: 4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e283655b5abe26462d53d5196f186c
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-31 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-16 20:17 [PATCH] drivers: macintosh: rack-meter: really fix bogus memsets Aaro Koskinen
2018-03-31 14:03 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).