From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <40DCBE32.2030008@mvista.com> Date: Fri, 25 Jun 2004 17:07:14 -0700 From: "Mark A. Greer" MIME-Version: 1.0 To: David Woodhouse Cc: Dieu Morales , linuxppc-embedded@lists.linuxppc.org, Brian Waite Subject: Re: GT64260_eth (Ethernet) Driver References: <20040620202719.25741.qmail@web60407.mail.yahoo.com> <40DA06BE.204@mvista.com> <1088066228.18627.3352.camel@hades.cambridge.redhat.com> <40DB2199.2050006@mvista.com> <1088147437.4636.114.camel@imladris.demon.co.uk> <40DCA1A3.6000401@mvista.com> <1088207000.4636.136.camel@imladris.demon.co.uk> In-Reply-To: <1088207000.4636.136.camel@imladris.demon.co.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: owner-linuxppc-embedded@lists.linuxppc.org List-Id: David Woodhouse wrote: >On Fri, 2004-06-25 at 15:05 -0700, Mark A. Greer wrote: > > >>Would you mind looking at the code, giving me feedback ("this totally >>sucks and needs to be thrown out" is perfectly valid) and looking for >>things I may have missed? >> >> > >For one, pci_auto sucks and needs to be thrown out. If the generic Linux >PCI resource assignment is broken, fix it rather than reimplementing it. > Point taken. I'll put it on the list but since its useful for testing right now, I make it a lower priority. >I'd also like to ditch the typedefs (use struct mv64x60_setup_info >instead of mv64x60_setup_info_t etc.). > Ahh, G*d I hate that...struct aaa, struct bbb, struct ccc all over the place when its not necessary & adds no value. Anyway, I will do that. > >Further than that I haven't noticed much yet -- my Friday ended before I >got the machine to boot. I think I relocated the chip to the wrong >address, because first the memory probe returned zero and then the PCI >idents were all 0xFFFF. I'll play some more on Monday. > >Thanks for the pointers. > Sure. Let me know how it goes. Mark ** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/