From: Nick Piggin <piggin@cyberone.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: linuxppc-dev@lists.linuxppc.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: Fw: 2.6.8-rc1-mm1 "Badness in schedule" on ppc32
Date: Thu, 15 Jul 2004 11:56:05 +1000 [thread overview]
Message-ID: <40F5E435.60503@cyberone.com.au> (raw)
In-Reply-To: <20040714161503.2b0ce4d9.akpm@osdl.org>
Andrew Morton wrote:
>Nick , Ingo: could you please appropriately berate the ppc developers
>over this? They're ignoring me ;)
>
>Or, if we don't really think the risk is very high, maybe I should just drop
>the debug patch?
>
>
sched-clean-init-idle has the following hunk to schedule() which
should catch all unsafe calls to it, I think.
+ /*
+ * The idle thread is not allowed to schedule!
+ * Remove this check after it has been exercised a bit.
+ */
+ if (unlikely(current == rq->idle) && current->state != TASK_RUNNING) {
+ printk(KERN_ERR "bad: scheduling from the idle thread!\n");
+ dump_stack();
+ }
+
Probably the patch can go.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2004-07-15 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 23:15 Fw: 2.6.8-rc1-mm1 "Badness in schedule" on ppc32 Andrew Morton
2004-07-15 1:56 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F5E435.60503@cyberone.com.au \
--to=piggin@cyberone.com.au \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).