From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [3/3] powerpc/powernv: Fix OPAL NVRAM driver OPAL_BUSY loops
Date: Thu, 12 Apr 2018 00:49:34 +1000 (AEST) [thread overview]
Message-ID: <40Ln4Z68p4z9s3X@ozlabs.org> (raw)
In-Reply-To: <20180410114933.24581-4-npiggin@gmail.com>
On Tue, 2018-04-10 at 11:49:33 UTC, Nicholas Piggin wrote:
> The OPAL NVRAM driver does not sleep in case it gets OPAL_BUSY or
> OPAL_BUSY_EVENT from firmware, which causes large scheduling
> latencies, and various lockup errors to trigger (again, BMC reboot
> can cause it).
>
> Fix this by converting it to the standard form OPAL_BUSY loop that
> sleeps.
>
> Fixes: 628daa8d5abfd ("powerpc/powernv: Add RTC and NVRAM support plus RTAS fallbacks")
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/3b8070335f751aac9f1526ae2e012e
cheers
prev parent reply other threads:[~2018-04-11 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 11:49 [PATCH 0/3] Fix RTC and NVRAM OPAL_BUSY loops Nicholas Piggin
2018-04-10 11:49 ` [PATCH 1/3] powerpc/powernv: define a standard delay for OPAL_BUSY type retry loops Nicholas Piggin
2018-04-11 14:49 ` [1/3] " Michael Ellerman
2018-04-10 11:49 ` [PATCH 2/3] powerpc/powernv: Fix OPAL RTC driver OPAL_BUSY loops Nicholas Piggin
2018-04-10 12:07 ` Alexandre Belloni
2018-04-10 13:01 ` Nicholas Piggin
2018-04-24 18:39 ` Alexandre Belloni
2018-04-25 3:28 ` Michael Ellerman
2018-04-25 9:41 ` Alexandre Belloni
2018-04-26 10:22 ` [2/3] " Michael Ellerman
2018-04-10 11:49 ` [PATCH 3/3] powerpc/powernv: Fix OPAL NVRAM " Nicholas Piggin
2018-04-11 14:49 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40Ln4Z68p4z9s3X@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).