From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Balbir Singh <bsingharora@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: rashmica.g@gmail.com
Subject: Re: [1/2] powerpc/mm: Flush cache on memory hot(un)plug
Date: Tue, 24 Apr 2018 13:48:25 +1000 (AEST) [thread overview]
Message-ID: <40VTnj1yHyz9s02@ozlabs.org> (raw)
In-Reply-To: <20180406052424.29841-1-bsingharora@gmail.com>
On Fri, 2018-04-06 at 05:24:23 UTC, Balbir Singh wrote:
> This patch adds support for flushing potentially dirty
> cache lines when memory is hot-plugged/hot-un-plugged.
> The support is currently limited to 64 bit systems.
>
> The bug was exposed when mappings for a device were
> actually hot-unplugged and plugged in back later.
> A similar issue was observed during the development
> of memtrace, but memtrace does it's own flushing of
> region via a custom routine.
>
> These patches do a flush both on hotplug/unplug to
> clear any stale data in the cache w.r.t mappings,
> there is a small race window where a clean cache
> line may be created again just prior to tearing
> down the mapping.
>
> The patches were tested by disabling the flush
> routines in memtrace and doing I/O on the trace
> file. The system immediately checkstops (quite
> reliablly if prior to the hot-unplug of the memtrace
> region, we memset the regions we are about to
> hot unplug). After these patches no custom flushing
> is needed in the memtrace code.
>
> Signed-off-by: Balbir Singh <bsingharora@gmail.com>
> Acked-by: Reza Arbab <arbab@linux.ibm.com>
> Reviewed-by: Rashmica Gupta <rashmica.g@gmail.com>
Series applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/fb5924fddf9ee31db04da7ad4e8c34
cheers
prev parent reply other threads:[~2018-04-24 3:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 5:24 [PATCH 1/2] powerpc/mm: Flush cache on memory hot(un)plug Balbir Singh
2018-04-06 5:24 ` [PATCH 2/2] powerpc/mm/memtrace: Let the arch hotunplug code flush cache Balbir Singh
2018-04-11 4:01 ` rashmica
2018-04-11 11:05 ` Michael Ellerman
2018-04-11 11:25 ` Balbir Singh
2018-04-09 21:14 ` [PATCH 1/2] powerpc/mm: Flush cache on memory hot(un)plug Reza Arbab
2018-04-11 4:00 ` rashmica
2018-04-24 3:48 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40VTnj1yHyz9s02@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rashmica.g@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).