From: Geoff Levand <geoff@infradead.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Michael Ellerman" <mpe@ellerman.id.au>
Cc: alsa-devel@alsa-project.org, Nicholas Piggin <npiggin@gmail.com>,
kernel@pengutronix.de, linux-tegra@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] ALSA: core: Make snd_card_free() return void
Date: Tue, 7 Feb 2023 18:10:19 -0800 [thread overview]
Message-ID: <40b2139d-274f-10c5-e74a-3849c94475ae@infradead.org> (raw)
In-Reply-To: <20230207191907.467756-4-u.kleine-koenig@pengutronix.de>
Hi Uwe,
On 2/7/23 11:19, Uwe Kleine-König wrote:
> The function returns 0 unconditionally. Make it return void instead and
> simplify all callers accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> include/sound/core.h | 2 +-
> sound/core/init.c | 6 ++----
> sound/pci/hda/hda_tegra.c | 6 ++----
> sound/ppc/snd_ps3.c | 4 +---
> 4 files changed, 6 insertions(+), 12 deletions(-)
> --- a/sound/ppc/snd_ps3.c
> +++ b/sound/ppc/snd_ps3.c
> @@ -1053,9 +1053,7 @@ static void snd_ps3_driver_remove(struct ps3_system_bus_device *dev)
> * ctl and preallocate buffer will be freed in
> * snd_card_free
> */
> - ret = snd_card_free(the_card.card);
> - if (ret)
> - pr_info("%s: ctl freecard=%d\n", __func__, ret);
> + snd_card_free(the_card.card);
>
> dma_free_coherent(&dev->core,
> PAGE_SIZE,
Looks OK for PS3.
Acked-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2023-02-08 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 19:19 [PATCH 0/3] ALSA: core: Make some functions return void Uwe Kleine-König
2023-02-07 19:19 ` [PATCH 3/3] ALSA: core: Make snd_card_free() " Uwe Kleine-König
2023-02-08 2:10 ` Geoff Levand [this message]
2023-02-08 11:33 ` Thierry Reding
2023-02-08 8:33 ` [PATCH 0/3] ALSA: core: Make some functions " Takashi Sakamoto
2023-02-08 9:25 ` Uwe Kleine-König
2023-02-08 8:39 ` Jaroslav Kysela
2023-02-08 12:41 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40b2139d-274f-10c5-e74a-3849c94475ae@infradead.org \
--to=geoff@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox