* [PATCH] powerpc/powernv/sriov: fix unsigned int win compared to less than zero
@ 2020-11-10 11:19 xiakaixu1987
2020-11-10 12:01 ` Andrew Donnellan
2020-11-25 11:58 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: xiakaixu1987 @ 2020-11-10 11:19 UTC (permalink / raw)
To: fbarrat, ajd, mpe, benh, paulus; +Cc: Kaixu Xia, linuxppc-dev, linux-kernel
From: Kaixu Xia <kaixuxia@tencent.com>
Fix coccicheck warning:
./arch/powerpc/platforms/powernv/pci-sriov.c:443:7-10: WARNING: Unsigned expression compared with zero: win < 0
./arch/powerpc/platforms/powernv/pci-sriov.c:462:7-10: WARNING: Unsigned expression compared with zero: win < 0
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
arch/powerpc/platforms/powernv/pci-sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/pci-sriov.c b/arch/powerpc/platforms/powernv/pci-sriov.c
index c4434f20f42f..92fc861c528f 100644
--- a/arch/powerpc/platforms/powernv/pci-sriov.c
+++ b/arch/powerpc/platforms/powernv/pci-sriov.c
@@ -422,7 +422,7 @@ static int pnv_pci_vf_assign_m64(struct pci_dev *pdev, u16 num_vfs)
{
struct pnv_iov_data *iov;
struct pnv_phb *phb;
- unsigned int win;
+ int win;
struct resource *res;
int i, j;
int64_t rc;
--
2.20.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/powernv/sriov: fix unsigned int win compared to less than zero
2020-11-10 11:19 [PATCH] powerpc/powernv/sriov: fix unsigned int win compared to less than zero xiakaixu1987
@ 2020-11-10 12:01 ` Andrew Donnellan
2020-11-17 3:07 ` Michael Ellerman
2020-11-25 11:58 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Donnellan @ 2020-11-10 12:01 UTC (permalink / raw)
To: xiakaixu1987, fbarrat, mpe, benh, paulus
Cc: Kaixu Xia, linuxppc-dev, linux-kernel
On 10/11/20 10:19 pm, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Fix coccicheck warning:
>
> ./arch/powerpc/platforms/powernv/pci-sriov.c:443:7-10: WARNING: Unsigned expression compared with zero: win < 0
> ./arch/powerpc/platforms/powernv/pci-sriov.c:462:7-10: WARNING: Unsigned expression compared with zero: win < 0
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
This seems like the right fix, the value assigned to win can indeed be
-1 so it should be signed. Thanks for sending the patch.
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
> ---
> arch/powerpc/platforms/powernv/pci-sriov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/pci-sriov.c b/arch/powerpc/platforms/powernv/pci-sriov.c
> index c4434f20f42f..92fc861c528f 100644
> --- a/arch/powerpc/platforms/powernv/pci-sriov.c
> +++ b/arch/powerpc/platforms/powernv/pci-sriov.c
> @@ -422,7 +422,7 @@ static int pnv_pci_vf_assign_m64(struct pci_dev *pdev, u16 num_vfs)
> {
> struct pnv_iov_data *iov;
> struct pnv_phb *phb;
> - unsigned int win;
> + int win;
> struct resource *res;
> int i, j;
> int64_t rc;
>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/powernv/sriov: fix unsigned int win compared to less than zero
2020-11-10 12:01 ` Andrew Donnellan
@ 2020-11-17 3:07 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2020-11-17 3:07 UTC (permalink / raw)
To: Andrew Donnellan, xiakaixu1987, fbarrat, benh, paulus
Cc: Kaixu Xia, linuxppc-dev, linux-kernel
Andrew Donnellan <ajd@linux.ibm.com> writes:
> On 10/11/20 10:19 pm, xiakaixu1987@gmail.com wrote:
>> From: Kaixu Xia <kaixuxia@tencent.com>
>>
>> Fix coccicheck warning:
>>
>> ./arch/powerpc/platforms/powernv/pci-sriov.c:443:7-10: WARNING: Unsigned expression compared with zero: win < 0
>> ./arch/powerpc/platforms/powernv/pci-sriov.c:462:7-10: WARNING: Unsigned expression compared with zero: win < 0
>>
>> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
>> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
>
> This seems like the right fix, the value assigned to win can indeed be
> -1 so it should be signed. Thanks for sending the patch.
>
> Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
I'll add:
Fixes: 39efc03e3ee8 ("powerpc/powernv/sriov: Move M64 BAR allocation into a helper")
Which I think is the culprit as it changed:
if (win >= phb->ioda.m64_bar_idx + 1)
to:
if (win < 0)
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/powernv/sriov: fix unsigned int win compared to less than zero
2020-11-10 11:19 [PATCH] powerpc/powernv/sriov: fix unsigned int win compared to less than zero xiakaixu1987
2020-11-10 12:01 ` Andrew Donnellan
@ 2020-11-25 11:58 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2020-11-25 11:58 UTC (permalink / raw)
To: ajd, paulus, fbarrat, mpe, xiakaixu1987@gmail.com, benh
Cc: linuxppc-dev, Kaixu Xia, linux-kernel
On Tue, 10 Nov 2020 19:19:30 +0800, xiakaixu1987@gmail.com wrote:
> Fix coccicheck warning:
>
> ./arch/powerpc/platforms/powernv/pci-sriov.c:443:7-10: WARNING: Unsigned expression compared with zero: win < 0
> ./arch/powerpc/platforms/powernv/pci-sriov.c:462:7-10: WARNING: Unsigned expression compared with zero: win < 0
Applied to powerpc/next.
[1/1] powerpc/powernv/sriov: fix unsigned int win compared to less than zero
https://git.kernel.org/powerpc/c/027717a45ca251a7ba67a63db359994836962cd2
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-25 13:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-10 11:19 [PATCH] powerpc/powernv/sriov: fix unsigned int win compared to less than zero xiakaixu1987
2020-11-10 12:01 ` Andrew Donnellan
2020-11-17 3:07 ` Michael Ellerman
2020-11-25 11:58 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).