From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
qiang.zhao@nxp.com, leoyang.li@nxp.com, nathan@kernel.org,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Tom Rix <trix@redhat.com>
Cc: linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v2] soc: fsl: qe: remove unused qe_ic_from_irq function
Date: Fri, 9 May 2025 18:16:50 +0200 [thread overview]
Message-ID: <40ccd7fb-a1c8-4fb0-8813-0575c4afe505@csgroup.eu> (raw)
In-Reply-To: <174680087395.258053.1870729490363422870.b4-ty@linaro.org>
Le 09/05/2025 à 16:28, Krzysztof Kozlowski a écrit :
>
> On Mon, 20 Mar 2023 08:52:02 -0400, Tom Rix wrote:
>> clang with W=1 reports
>> drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function
>> 'qe_ic_from_irq' [-Werror,-Wunused-function]
>> static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
>> ^
>> The use of this function was removed with
>> commit d7c2878cfcfa ("soc: fsl: qe: remove unused qe_ic_set_* functions")
>>
>> [...]
>
>
> Commit from 2021:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F1619002613-18216-1-git-send-email-jiapeng.chong%40linux.alibaba.com%2F&data=05%7C02%7Cchristophe.leroy2%40cs-soprasteria.com%7Cd5ee085f1ff64e69aec608dd8f05d608%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638823977413929827%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=kaeZGwikWMhIhz9iC6ZEVs%2Ffbd9UsZHJz7vBbODUHgg%3D&reserved=0
>
> did not apply, but this applies.
>
> I am annoying hitting this warning on every W=1 build, so:
Acked-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Applied, thanks!
>
> [1/1] soc: fsl: qe: remove unused qe_ic_from_irq function
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fkrzk%2Flinux-dt%2Fc%2Fd47f1233374597c348696c3da2142cc92a36fc90&data=05%7C02%7Cchristophe.leroy2%40cs-soprasteria.com%7Cd5ee085f1ff64e69aec608dd8f05d608%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638823977413952218%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=HzwgkKFqffwtkmoskS9Y1OhlXShSW%2B%2BZLKxc3k3fCpA%3D&reserved=0
>
> Best regards,
prev parent reply other threads:[~2025-05-09 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 12:52 [PATCH v2] soc: fsl: qe: remove unused qe_ic_from_irq function Tom Rix
2023-03-20 13:42 ` Christophe Leroy
2025-05-09 14:28 ` Krzysztof Kozlowski
2025-05-09 16:16 ` LEROY Christophe
2025-05-09 16:16 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40ccd7fb-a1c8-4fb0-8813-0575c4afe505@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=qiang.zhao@nxp.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).