From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: aik@ozlabs.ru, paulus@samba.org
Subject: Re: [2/5] powerpc/lib: Fix feature fixup test of external branch
Date: Wed, 16 May 2018 23:38:45 +1000 (AEST) [thread overview]
Message-ID: <40mFrj4Z7Bz9s3B@ozlabs.org> (raw)
In-Reply-To: <20180416143905.2716-2-mpe@ellerman.id.au>
On Mon, 2018-04-16 at 14:39:02 UTC, Michael Ellerman wrote:
> The expected case for this test was wrong, the source of the alternate
> code sequence is:
>
> FTR_SECTION_ELSE
> 2: or 2,2,2
> PPC_LCMPI r3,1
> beq 3f
> blt 2b
> b 3f
> b 1b
> ALT_FTR_SECTION_END(0, 1)
> 3: or 1,1,1
> or 2,2,2
> 4: or 3,3,3
>
> So when it's patched the '3' label should still be on the 'or 1,1,1',
> and the 4 label is irrelevant and can be removed.
>
> Fixes: 362e7701fd18 ("powerpc: Add self-tests of the feature fixup code")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Patches 2-5 applied to powerpc next.
https://git.kernel.org/powerpc/c/32810d91325ec76b8ef4df463f8a0e
cheers
next prev parent reply other threads:[~2018-05-16 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 14:39 [PATCH 1/5] powerpc/lib: Fix off-by-one in alternate feature patching Michael Ellerman
2018-04-16 14:39 ` [PATCH 2/5] powerpc/lib: Fix feature fixup test of external branch Michael Ellerman
2018-05-16 13:38 ` Michael Ellerman [this message]
2018-04-16 14:39 ` [PATCH 3/5] powerpc/lib: Fix the feature fixup tests to actually work Michael Ellerman
2018-04-16 14:39 ` [PATCH 4/5] powerpc/lib: Rename ftr_fixup_test7 to ftr_fixup_test_too_big Michael Ellerman
2018-04-16 14:39 ` [PATCH 5/5] powerpc/lib: Add alt patching test of branching past the last instruction Michael Ellerman
2018-04-17 10:13 ` [1/5] powerpc/lib: Fix off-by-one in alternate feature patching Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40mFrj4Z7Bz9s3B@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).